search

esheldon / fitsio

A python package for FITS input/output wrapping cfitsio
GNU General Public License v2.0
134 stars 58 forks source link

add zlib to manifest #400

Closed esheldon closed 5 months ago

esheldon commented 5 months ago

This may address #399

beckermr commented 5 months ago

One thing that can be done in ci is we can make an sdist and the try to directly build it.

esheldon commented 5 months ago

It makes sense to use test.pypi to test release candidates for this but unfortunately @rainwoodman owns a package called fitsio there. Is there a way to let me upload to that?

esheldon commented 5 months ago

In the mean time I agree we can do the sdist in the CI

esheldon commented 5 months ago

The wrong cfitsio version in the manifest was probably the culprit, but including zlib there also makes sense I think.

esheldon commented 5 months ago

I don't have a way to test this with test.pypi so I'm going to try for a release at 1.2.3 unless there is an objection