search

esheldon / metadetect

Library for meta-detection, combining detection and metacalibration
Other
11 stars 5 forks source link

use sheared positions for LSST mfrac #178

Closed esheldon closed 2 years ago

esheldon commented 2 years ago

I am. Unsheared positions are not even calculated.

esheldon commented 2 years ago

https://github.com/esheldon/metadetect/blob/17ccf950dc39a6d3e54ca11f4537551d68726050/metadetect/lsst/measure.py#L271

esheldon commented 2 years ago

the bmasks were always using sheared positions

beckermr commented 2 years ago

Wait, so that means my whole thing of the positions having to be consistent was never true here?

esheldon commented 2 years ago

the mfrac were using the unsheared positions, but trimming was using sheared positions, so there was a mismatch

beckermr commented 2 years ago

Ouch. So whatever effect I found in my sims did not happen here. Yikes ok.