search

esheldon / metadetect

Library for meta-detection, combining detection and metacalibration
Other
12 stars 6 forks source link

adaptive moments and pgauss smoothing #194

Closed esheldon closed 2 years ago

esheldon commented 2 years ago

CI isn't running

esheldon commented 2 years ago

https://www.githubstatus.com/incidents/qzmhbwp7f6nn

esheldon commented 2 years ago

shall we merge this after the other PR to get the ngmix upstream fixes?

beckermr commented 2 years ago

Yes. I have three PRs to be merged.

https://github.com/esheldon/metadetect/pull/195 https://github.com/esheldon/ngmix/pull/219 https://github.com/esheldon/ngmix/pull/220

beckermr commented 2 years ago

You likely want to merge master into this branch to get the tests to pass with old ngmix versions.

Also for AM, you'll need to detect the ngmix version and use the old mom name if you want this to run with older ngmix. You can import MOMNAME from fitting and that has the right prefix.

esheldon commented 2 years ago

I did merge master

beckermr commented 2 years ago

Ack I missed the master merge. Admom is only one band so we don't care about sums_norm in principle.

beckermr commented 2 years ago

So the test failure is from passing fwhm_smooth to older versions of the fitters that did not support that. You can avoid this by passing **kwargs if the smoothing is > 0 or you can simply wait for ngmix 2.1

beckermr commented 2 years ago

Shall we merge?