search

esheldon / metadetect

Library for meta-detection, combining detection and metacalibration
Other
12 stars 6 forks source link

BUG use flux weighting for PSF moment sums #195

Closed beckermr closed 2 years ago

beckermr commented 2 years ago

This PR adds flux weighting to the PSF sums so that it matches the object. It should fix the weird wmom stuff we found.

beckermr commented 2 years ago

OK @esheldon This one is ready for review!

beckermr commented 2 years ago

OK @esheldon. This is ready for another look!

esheldon commented 2 years ago

There should be a fast test that will show this gives T/Tpsf ~ 1.0 for wmom, but would not if we didn't use the flux ratio

beckermr commented 2 years ago

There should be a fast test that will show this gives T/Tpsf ~ 1.0 for wmom, but would not if we didn't use the flux ratio

I added a test. Did you not think it was sufficient?