search

esheldon / metadetect

Library for meta-detection, combining detection and metacalibration
Other
12 stars 6 forks source link

Make input optional for get_detection_mask #222

Closed arunkannawadi closed 1 month ago

arunkannawadi commented 1 month ago

In #218 , @esheldon introduced get_detection_mask function, which sets the config depending on the Exposure data. This interferes with the upcoming refactoring indicated in #220 , since config values must be set before any data is processed. The minimally distruptive solution seems to be making the input argument optional. Based on this, BRIGHT mask plane is also deprecated, so I don't expect any issues because of not providing the input argument.

beckermr commented 1 month ago

I need to understand the refactoring before I can comment further on this.

arunkannawadi commented 1 month ago

Does the refactoring aspect matter here? All the call in this repo can still pass the argument.