search

eshepelyuk / cmak-docker

CMAK (prev. Kafka Manager) and cmak2zk docker images
Apache License 2.0
221 stars 75 forks source link

Remove KAFKA_MANAGER_VERSION env from Dockerfile #11

Closed hleb-albau closed 4 years ago

hleb-albau commented 5 years ago

To update the image for a new version, you need to change 2 ENV variables in Dockerfile. The first one is KAFKA_MANAGER_SOURCE - a point to git commit(either tag or version). The second is KAFKA_MANAGER_VERSION - used only to unzip sbt build output archive (archive contains version as part of a name).

Todo: eliminate KAFKA_MANAGER_VERSION variable from Dockerfile and .sh scripts. Use only bash utils to get required folders names

Expected behavior: user updates only KAFKA_MANAGER_SOURCE -> docker image is built successfully using docker build . command.

hleb-albau commented 5 years ago

Leave it for community contributors!

IRus commented 5 years ago

You like to get tag (if any) that commit has? What is expected behavior, in case if no tag associated with commit?

hleb-albau commented 5 years ago

You like to get tag (if any) that commit has? What is expected behavior, in case if no tag associated with commit?

Create a separate issue for our discussion.