search

eshepelyuk / cmak-operator

CMAK (prev. Kafka Manager) for Kubernetes
MIT License
59 stars 27 forks source link

feat: Extend the chart for basicAuth #54

Closed jack1902 closed 2 years ago

jack1902 commented 2 years ago

Extends the chart such that it is possible to use basicAuth by having the password mapped from a secret to an env-var.

This ensures that those with read-only access to a cluster cannot see the password, as it is not exposed in plain text in the deployment manifest.

fixes: https://github.com/eshepelyuk/cmak-operator/issues/53

Additionally, ensures that env is only ever set in the chart, if any env is actually used. Without the if or a bug can occur whereby env: is null and results in a broken render

jack1902 commented 2 years ago

Will close as it is technically possible to use extra* settings within the chart to use a previously created secret containing the information.