Clicking a checkbox while filtering by name refreshes the filter but does not check the box

esheyw / find-the-culprit

MIT License

2 stars 1 forks source link

Clicking a checkbox while filtering by name refreshes the filter but does not check the box #9

Closed GambetTV closed 5 days ago

GambetTV commented 2 weeks ago

When you use Find the Culprit's filter, and then click one of the checkboxes, you'll see a brief flash of the filter refreshing, and the checkbox won't be checked. After this you can click on the checkbox again and it works, but this is an annoying little hiccup of a bug.

esheyw commented 5 days ago

Hi, sorry for missing this, I haven't been getting notifications properly for this repo.

The flicker is because the render wasn't building in the hidden class, it was having to be applied immediately post render. In addition to all the other things version 3.0 changed, I now grab the hidden state pre-render and carry it over, eliminating the flicker, theoretically. If you're still getting some in v3 let me know, but closing this for now.