eshivakant / google-api-dotnet-client

Automatically exported from code.google.com/p/google-api-dotnet-client
Apache License 2.0
0 stars 0 forks source link

Unicode characters are lost due to ASCII encoding #88

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
   An example - create a task with non-ASCII title.

What is the expected output?
   task with the same name to be created

What do you see instead?
   there is a task with a set of "?" symbols in title.

What version of the product are you using? On what operating system?
   assembly Google.Apis, Version=0.9.0.26734

Please provide any additional information below:

Mistake locates in Google.Apis.Requests.Request.AttachBody method.
There is:  byte[] bytes = Encoding.ASCII.GetBytes(this.Body);
Should be: byte[] bytes = Encoding.UTF8.GetBytes(this.Body);

After changing the code seems to work fine.

Original issue reported on code.google.com by a...@tomin.kiev.ua on 14 Jul 2011 at 2:14

GoogleCodeExporter commented 9 years ago
Thanks for the report and the bugfix! I'll look into that shortly.

Original comment by mlin...@google.com on 14 Jul 2011 at 4:02

GoogleCodeExporter commented 9 years ago
http://codereview.appspot.com/4754042/

Original comment by mlin...@google.com on 15 Jul 2011 at 2:57

GoogleCodeExporter commented 9 years ago
Fixed in revision 592.

Original comment by mlin...@google.com on 27 Jul 2011 at 9:04