esi-neuroscience / oephys2nwb

Export Open Ephys binary data to NWB 2.0
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

TTLs expect labels #1

Closed KatharineShapcott closed 2 years ago

KatharineShapcott commented 2 years ago

Hi Stefan, Reading through the code it looks great, thanks so much! I just started doing some testing and realised that the TTL from ndx-events is expecting "labels".

Since that doesn't make any sense in our case (we would need 32000 labels!) I found out that adding this to TTL_Pulses and TTL_Channels works fine: labels=['']

I can add that if you're happy with it?

pantaray commented 2 years ago

Hi Katharine! My bad - sorry, I commited but didn't push my latest changes... Thanks for the fix!