search

esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
208 stars 23 forks source link

Unexpected 500 http code on previously working character endpoint #1060

Open cvweiss opened 5 years ago

cvweiss commented 5 years ago

Bug

https://esi.evetech.net/v4/characters/2029709492/

The above URL has worked in the past, as I've fetched the name, security status, etc and have stored this information in my database.

Request

GET https://esi.evetech.net/v4/characters/2029709492/

Status Code

500

Headers

< HTTP/2 500 
< date: Sat, 03 Nov 2018 12:53:01 GMT
< content-type: application/json; charset=UTF-8
< content-length: 49
< access-control-allow-credentials: true
< access-control-allow-headers: Content-Type,Authorization,If-None-Match,X-User-Agent
< access-control-allow-methods: GET,HEAD,OPTIONS
< access-control-allow-origin: *
< access-control-expose-headers: Content-Type,Warning,ETag,X-Pages,X-ESI-Error-Limit-Remain,X-ESI-Error-Limit-Reset
< access-control-max-age: 600
< allow: GET,HEAD,OPTIONS
< strict-transport-security: max-age=31536000
< x-esi-error-limit-remain: 99
< x-esi-error-limit-reset: 59
< x-esi-request-id: ac2e24a7-bd15-433e-aec5-5c804c66960b

Body

Please provide the response body, feel free to scrub any opsec details you wish. E.g.:

    {
    "error": "Unhandled internal error encountered!"
    }

Expected

200

Along with a body containing the json of the character's information.

Checklist

Check all boxes that apply to this issue:

cvweiss commented 5 years ago

Same issue as above:

https://esi.evetech.net/v4/characters/504629349/
https://esi.evetech.net/v4/characters/1186256244/
https://esi.evetech.net/v4/characters/1695168885/
https://esi.evetech.net/v4/characters/1722802935/
https://esi.evetech.net/v4/characters/999093110/

there are more, but hopefully this will give a large enough sample size to fix the underlying issue.

stephenswat commented 5 years ago

I doubt this is an ESI issue. If you try to open these characters in game (by creating a custom showinfo URL, such as <url=showinfo:1379//2029709492>Mystery Toon</url>) the info window will hang and no character will be loaded. That's the same behaviour that you get when you try to show info for a completely random character ID. Perhaps these are characters that existed before and, instead of being moved to Doomheim, were deleted completely for whatever reason?

Addendum: The /universe/names/ endpoint also returns an error when trying to look up these IDs.

cvweiss commented 5 years ago

The fact in game is affected will help with debugging. I don't think these characters have been fully deleted, they have however had their names changed to the default <Race> Characer <ID>.

Ionaru commented 5 years ago

Interestingly https://imageserver.eveonline.com/Character/2029709492_256.jpg does have an image for this (deleted?) character.

ccp-zoetrope commented 5 years ago

This now throws a 404 instead of 500 after today's downtime. These characters do not exist in the system anymore and therefore it is a 404.

cvweiss commented 5 years ago

As in completely gone, not just doomheimed?

Reason I ask is this hasn't happened to characters in the past, and these characters have killmail records, so it will be difficult to pull their name(s), even if its just <Racial> Character <ID> and/or corporation history.

ccp-zoetrope commented 5 years ago

@cvweiss yes, it is odd and I have not really seen it before so I will look a bit more into why that is.

CarbonAlabel commented 5 years ago

@ccp-zoetrope see https://github.com/esi/esi-issues/issues/936 for how you handled the same thing about 6 months ago.

ccp-zoetrope commented 5 years ago

@CarbonAlabel always nice to have people around that have a way better memory than me 😆

cvweiss commented 5 years ago

@ccp-zoetrope while you're re-looking into this, can you reopen the ticket please?

ccp-zoetrope commented 5 years ago

Reopening until I can find out why characters were flat out deleted.

ccp-zoetrope commented 5 years ago

@cvweiss seems this was a bug with the first round of gdpr deletions and these characters will be restored. Please throw in any character IDs you know of that throw 404's.

ghost commented 5 years ago

Does this ticket still need to be open?

cvweiss commented 5 years ago

I'd say yes since the characters listed above were once valid entities and are now no longer valid entities. Previous discussions were that the characters were flat out deleted, rather than having the character's name changed.

ghost commented 5 years ago

Rgr, talking to people about it now