esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
209 stars 23 forks source link

Use expanded ref_types in corp journal #1062

Open nic-southern opened 6 years ago

nic-southern commented 6 years ago

Feature Request

Expansion of corporations/{corporation_id}/wallets/{division}/journal/ Could we expand the corporation journal endpoint, so the ref_type returns more descriptive information? According to this page: https://github.com/esi/eve-glue/blob/master/eve_glue/wallet_journal_ref.py , the types are all there and they are listed on the swagger UI model. Currently it only returns industry_job_tax. It would be very useful to have it return the others such as:

Use case

Analytic tools and internal metrics for alliances/structure owners.

Authentication

Uses same auth as current

Example return

[
  {
    "amount": 999.99,
    "balance": 99999999.87,
    "context_id": 123123123,
    "context_id_type": "industry_job_id",
    "date": "2018-11-17T23:16:51Z",
    "description": "Industry facility tax between Client and Owner (Job ID: 11112222)",
    "first_party_id": 11223344,
    "id": 999999999,
    "ref_type": "reaction",
    "second_party_id": 44332211
  },
]

Checklist

Check all boxes that apply to this issue:

Blacksmoke16 commented 6 years ago

@jeronica

image

This is already a thing i think. The context_id ties together the related transactions. For example that shows the tax paid for a copy ME research job, then another for the tax to the structure owner. Which is the current behavior you wanted for your feature request?

EDIT: @jeronica Clarified this is in the context of a structure owner, which doesn't offer the same info.

nic-southern commented 6 years ago

After some discussion on slack, explained that on the structure owner side we get the generic ref_type. Personal testing shows that the tax paid from the character is also the same ref_type to the structure corp, and the descriptive type is sent to SCC/NPC.

I guess the request would be to add/replace the context_id_type, if at all possible, or a way to differentiate between industry job types.