search

esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
207 stars 23 forks source link

SDE parity checklist #1103

Open CarbonAlabel opened 5 years ago

CarbonAlabel commented 5 years ago

This checklist consists of all the files from the SDE, a short description of their contents, and the current status of an ESI replacement for them, with the purpose of showing how close ESI is to achieving SDE parity.

Checked boxes indicate that a part of the SDE has an ESI equivalent or is in some way obsolete, while unchecked ones mean that more work is required to reach parity. If you disagree on my judgement on some of them, or think I've missed something, feel free to comment on this issue.

ghost commented 5 years ago

Thoughts on this list:

  1. Races and bloodlines are both pretty small, could they usefully be combined into one endpoint?
  2. is contraband even still a thing? e: yes it is, but there's not much on the contraband list these days, all lore items
  3. At least some of the planet schematic stuff is covered in the PI endpoints, right? Do we just need some kind of index list for the PI schematics so you can know the full set?
ghost commented 5 years ago

Also, it's a monster but localization isn't on this list and I know it's in the SDE. The performance implications of letting people traverse it via API might be pretty bad though, loading the entire localization tree can take a few minutes on a desktop with an SSD.

CarbonAlabel commented 5 years ago
  1. Could also squeeze ancestries in there, but why? They all already have their own endpoints.
  2. Would making it not a thing at all be an option?
  3. It's also that the current schematic endpoint doesn't tell you anything about what its inputs/outputs are.
  4. Didn't forget about it, it's marked as completed on the list since most endpoints have built in localization.
ghost commented 5 years ago

Ah, I thought they were unticked because they were totally missing, but I see they're just missing some stuff.

rayanth commented 5 years ago

https://esi.evetech.net/ui/?version=_dev#/Market/get_markets_groups_market_group_id does not return the iconid that is in the yaml. We still need the SDE to link a market group to its icon, since the icon id's are not the same numbering.

CarbonAlabel commented 5 years ago

Since both the SDE and the IEC (which is where you'd most likely get the icon itself from) are on the track to be deprecated, a proper solution would be ensuring the image server can directly return the icons for market groups.

GoldenGnu commented 5 years ago

invFalgs.yaml is marked as done, but, there is no way to translate the enum value to the text used in-game. Glue only translate the enum to the sde flag_id. This is true for almost all the enum values in ESI

rayanth commented 5 years ago

Since both the SDE and the IEC (which is where you'd most likely get the icon itself from) are on the track to be deprecated, a proper solution would be ensuring the image server can directly return the icons for market groups.

Agreed, but the further I dig, the further it makes less sense - /universe/types/{type_id}/ has the icon_id, but /universe/groups/{group_id}/ and /universe/categories/{category_id}/ do not.

GoldenGnu commented 5 years ago

typeIDs.yaml is marked as done, but, there is no way to get basePrice in ESI

rayanth commented 5 years ago

typeIDs.yaml is marked as done, but, there is no way to get race in ESI on ships