Open rayanth opened 5 years ago
IIRC I think they would be more inclined to remove the id from the ones that include as opposed to adding it to the ones it's missing from.
We would be more inclined to remove these id's from the responses, as they should be contained in the context of the request.
Related to #273 but provides more info, and additional endpoints.
In some frameworks it is less efficient to try to match results to requests than it is to simply have the id in the response. This also greatly improves readability of code, makes threading easier, and assists in creating foreign-key relations on the receiving end. There are three /universe/ endpoints that do NOT return their ID in the response.
Inconsistency
Most Universe endpoints contain their own id:
category_id
in responseconstellation_id
in responsegraphic_id
in responsegroup_id
in responsemoon_id
in responseplanet_id
in responseregion_id
in responsestargate_id
in responsestation_id
in responsesystem_id
in responsetype_id
in response.These detail end points do NOT:
asteroid_belt_id
from responsestar_id
from responsestructure_id
from responseRoutes
GET /v1/universe/asteroid_belts/{asteroid_belt_id}/
GET /v1/universe/stars/{star_id}/
GET /v2/universe/structures/{structure_id}/
Resolution
Add noted id's to the three endpoints in Universe that are missing them.
Checklist