esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
208 stars 23 forks source link

Not all Universe Detail Endpoints contain their own id in response #1122

Open rayanth opened 5 years ago

rayanth commented 5 years ago

Related to #273 but provides more info, and additional endpoints.

In some frameworks it is less efficient to try to match results to requests than it is to simply have the id in the response. This also greatly improves readability of code, makes threading easier, and assists in creating foreign-key relations on the receiving end. There are three /universe/ endpoints that do NOT return their ID in the response.

Inconsistency

Most Universe endpoints contain their own id:

These detail end points do NOT:

Routes

Resolution

Add noted id's to the three endpoints in Universe that are missing them.

Checklist

Blacksmoke16 commented 5 years ago

IIRC I think they would be more inclined to remove the id from the ones that include as opposed to adding it to the ones it's missing from.

gitAskur commented 4 years ago

We would be more inclined to remove these id's from the responses, as they should be contained in the context of the request.