esi / esi-issues

Issue tracking and feature requests for ESI

https://esi.evetech.net/

208 stars 23 forks source link

characters/{character_id}/assets returns unspecified 404 #1258

Open wvdvegt opened 3 years ago

wvdvegt commented 3 years ago

Bug

After a number of pages, get_characters_character_id_assets returns

{"error":"Undefined 404 response. Original message: Requested page does not exist!"}

This response code is however not specified in the swagger definition.

Request

https://esi.evetech.net/dev/characters/{character_id}/assets/

Response

Status Code

404

Headers

Body

{"error":"Undefined 404 response. Original message: Requested page does not exist!"}

Expected

Should be specified in the swagger definition. Seems a request beyond the last page.

Checklist

Check all boxes that apply to this issue:

[x] Bug description is provided
[x] Request path is provided
[x] Response status code is provided
[ ] Response headers are provided
[x] Response body is provided
[x] Expected response is provided

Blacksmoke16 commented 3 years ago

This should be updated in the Swagger docs to specify this. However this isn't a bug per-say. The solution is to do pagination properly. See https://developers.eveonline.com/blog/article/esi-concurrent-programming-and-pagination.