Open CarbonAlabel opened 7 years ago
1024x1024 possibly shouldn't be returned as it isn't listed as supported and some characters return 512x512 when calling for the 1024x1024.
How about static endpoints with full descriptions? Something like:
GET /characters/portraits/
{
"substring": "<character_id>",
"images": [
{
"id": 1,
"format": "jpg",
"width": 64,
"height": 64,
"link": "https://imageserver.eveonline.com/Character/<character_id>_64.jpg"
}
]
}
And return list of available image ids for specific character.
we could do hacky things in esi to fix this, but it should be fixed in the monolith action get_services-v1
The endpoints do not appear to validate the supplied IDs, instead just inserting the provided integer into a string, possibly returning invalid URLs instead of an error.
Especially true for alliances. Using the /alliances/{alliance_id}/icons/
endpoint with a valid alliance with no logo will provide a URL that just redirects, rather than providing an error that the alliance does not have a logo.
A request has been made to change the base URL from http://image.eveonline.com to https://imageserver.eveonline.com in TQ's DB, this should happen some time this week.
Any update on this? The endpoints are now using a proper URL origin for SISI (https://image.testeveonline.com), but the one for TQ has only been changed to http://imageserver.eveonline.com (not https) instead of https://imageserver.eveonline.com.
The Alliance, Corporation and Alliance endpoint are now returning. https://images.evetech.net So we have https and on the new(?) image server.
This should probably be looked at again in light of the new image service. Are the image / portrait endpoints even still required once the image service is at a point where it is stable?
Being that it's the only one available, it doesn't much matter if it's stable or not.
And yes, these endpoints don't make much sense anymore, it would probably be best to deprecate them and schedule their removal.
[ ] The image server can deliver sizes down to 32x32, but the smallest size included in any of the responses is 64x64.
[ ] The character portrait endpoint does not return the 1024x1024 size.
[ ] The URLs returned by the endpoints (unlike the example values in the documentation) are HTTP instead of HTTPS and are using the old image.eveonline.com domain instead of the new imageserver.eveonline.com domain.
[x] The endpoints return URLs for the TQ image server regardless of the requested data source.
[ ] The endpoints do not appear to validate the supplied IDs, instead just inserting the provided integer into a string, possibly returning invalid URLs instead of an error.
Endpoints affected:
/alliances/{alliance_id}/icons/
/characters/{character_id}/portrait/
/corporations/{corporation_id}/icons/