esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
209 stars 23 forks source link

500 Error in corporate assets "Invalid 200 response: 'location_type' is required, 'location_flag' is required" #1352

Closed pvyParts closed 4 months ago

pvyParts commented 1 year ago

Bug

ESI intermitently returns an error when requesting corporate assets

Invalid 200 response: 'location_type' is required, 'location_flag' is required

Request

curl -X GET "https://esi.evetech.net/latest/corporations/98602306/assets/?datasource=tranquility&page=1&token=123abc" -H "accept: application/json" -H "Cache-Control: no-cache"

Response

Status Code

500

Headers

Include relevant headers received. Timestamps and request ID is nice, you may not have all these values, fill out what you received (don't worry about headers not listed here, unless pertinent to your issue). E.g.:

 date: Sun, 18 Jun 2023 07:51:46 GMT 
 x-esi-request-id: 8d4b9040-0494-4a34-9c38-d88da791cbbf 

Body

Please provide the response body, feel free to scrub any opsec details you wish. E.g.:

{
  "error": "Invalid 200 response: 'location_type' is required, 'location_flag' is required",
  "response": [
    {
      "is_blueprint_copy":false,
      "type_id":2048,
      "is_singleton":false,
      "item_id":1041817873460,
      "location_id":1036957801720,
      "quantity":1
    }
    999 other items that are valid
  ],
  "sentry_id": "065617b2f43e4f72b7cca998b1f8700e"
}

That location ID is an office folder in a keepstar in nullsec. more details can be given if needed.

Expected

Please provide either the expected return code, correct response body, header value, or some combination thereof. E.g.:

200 and a list of items as per the spec

Checklist

Check all boxes that apply to this issue:

MrRuthMN commented 1 year ago

Appears to be due to the new corporation project hangar added in the Viridian expansion. Items from contributing to a corp project stored in this hangar don't have a location_flag value passed, causing the request to error. Removing all items from the project hangar and waiting for the endpoint cache to refresh resolved the issue for us.

See the following example. The first item is in corp deliveries and has a location_flag value. 2nd item was in the new project hangar, missing the location_flag value. ESI Example

soratidus999 commented 4 months ago

CorporationGoalDeliveries should have been added last year https://github.com/esi/eve-glue/commit/1824792d04c14f6bf4e5839735d812b6e6b33231

Can you confirm?

pvyParts commented 4 months ago

I haven't seen this in a very long time so assume fixed yes.