esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
208 stars 23 forks source link

EVE v21.06 - /fw/wars/ Invalid 200 response: too many items for 'response' #1364

Closed soratidus999 closed 9 months ago

soratidus999 commented 10 months ago

Bug

EVE 21.06 added Additional Factions involved in Faction Warfare (Pirate Insurgencies)

The wars endpoint is throwing an error 500 (although still nicely returning the internal 200 response)

Request

https://esi.evetech.net/ui/#/Faction%20Warfare/get_fw_wars GET /latest/fw/wars/?datasource=tranquility

Response

Status Code

500

Headers

access-control-allow-credentials: true 
 access-control-allow-headers: Content-Type,Authorization,If-None-Match,X-User-Agent 
 access-control-allow-methods: GET,HEAD,OPTIONS 
 access-control-allow-origin: * 
 access-control-expose-headers: Content-Type,Warning,ETag,X-Pages,X-ESI-Error-Limit-Remain,X-ESI-Error-Limit-Reset 
 access-control-max-age: 600 
 allow: GET,HEAD,OPTIONS 
 content-length: 627 
 content-type: application/json; charset=UTF-8 
 date: Tue, 14 Nov 2023 11:39:55 GMT 
 etag: W/"3280a2bbc63957e7734f99376d30b5f3f3f00157a0421321d9b95d62" 
 strict-transport-security: max-age=31536000 
 x-esi-error-limit-remain: 99 
 x-esi-error-limit-reset: 5 
 x-esi-request-id: c44b0412-2060-406a-9a95-466974ee83d6 

Body

{
  "error": "Invalid 200 response: too many items for 'response'",
  "response": [
    {
      "faction_id": 500001,
      "against_id": 500004
    },
    {
      "faction_id": 500001,
      "against_id": 500010
    },
    {
      "faction_id": 500002,
      "against_id": 500003
    },
    {
      "faction_id": 500002,
      "against_id": 500011
    },
    {
      "faction_id": 500003,
      "against_id": 500002
    },
    {
      "faction_id": 500003,
      "against_id": 500011
    },
    {
      "faction_id": 500004,
      "against_id": 500001
    },
    {
      "faction_id": 500004,
      "against_id": 500010
    },
    {
      "faction_id": 500010,
      "against_id": 500001
    },
    {
      "faction_id": 500010,
      "against_id": 500004
    },
    {
      "faction_id": 500011,
      "against_id": 500003
    },
    {
      "faction_id": 500011,
      "against_id": 500002
    }
  ],
  "sentry_id": "147163d1ed4740a68d074a6fe658a54c"
}

Expected

HTTP 200, This is obviously working internally but the esi ?wrapper? is confused due to the additional wars being returned.

Checklist

Check all boxes that apply to this issue:

soratidus999 commented 9 months ago

This has been fixed, going to presume the fixes to https://github.com/esi/esi-issues/issues/1365 also flowed onto this endpoint