esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
208 stars 23 forks source link

EVE v21.06 - /fw/stats/ Invalid 200 response: too many items for 'response' #1365

Closed soratidus999 closed 10 months ago

soratidus999 commented 10 months ago

Bug

EVE 21.06 added Additional Factions involved in Faction Warfare (Pirate Insurgencies)

The stats endpoint is throwing an error 500 (although still nicely returning the internal 200 response)

Request

GET /latest/fw/stats/?datasource=tranquility

Response

Status Code

500

Headers

access-control-allow-credentials: true 
 access-control-allow-headers: Content-Type,Authorization,If-None-Match,X-User-Agent 
 access-control-allow-methods: GET,HEAD,OPTIONS 
 access-control-allow-origin: * 
 access-control-expose-headers: Content-Type,Warning,ETag,X-Pages,X-ESI-Error-Limit-Remain,X-ESI-Error-Limit-Reset 
 access-control-max-age: 600 
 allow: GET,HEAD,OPTIONS 
 content-encoding: gzip 
 content-length: 422 
 content-type: application/json; charset=UTF-8 
 date: Wed, 15 Nov 2023 11:33:26 GMT 
 etag: W/"3280a2bbc63957e7734f99376d30b5f3f3f00157a0421321d9b95d62" 
 strict-transport-security: max-age=31536000 
 vary: Accept-Encoding 
 x-esi-error-limit-remain: 98 
 x-esi-error-limit-reset: 34 
 x-esi-request-id: 271268ff-e0bf-4b8d-8fe3-c2b581bf5101 

Body

{
  "error": "Invalid 200 response: too many items for 'response'",
  "response": [
    {
      "faction_id": 500001,
      "pilots": 52221,
      "systems_controlled": 60,
      "kills": {
        "yesterday": 361,
        "last_week": 2375,
        "total": 1029065
      },
      "victory_points": {
        "yesterday": 95877,
        "last_week": 780124,
        "total": 115371291
      }
    },
    {
      "faction_id": 500002,
      "pilots": 32537,
      "systems_controlled": 57,
      "kills": {
        "yesterday": 586,
        "last_week": 2432,
        "total": 853171
      },
      "victory_points": {
        "yesterday": 38987,
        "last_week": 716186,
        "total": 82537546
      }
    },
    {
      "faction_id": 500003,
      "pilots": 30309,
      "systems_controlled": 13,
      "kills": {
        "yesterday": 343,
        "last_week": 2296,
        "total": 903503
      },
      "victory_points": {
        "yesterday": 68322,
        "last_week": 633759,
        "total": 82511138
      }
    },
    {
      "faction_id": 500004,
      "pilots": 43102,
      "systems_controlled": 30,
      "kills": {
        "yesterday": 382,
        "last_week": 2966,
        "total": 1256705
      },
      "victory_points": {
        "yesterday": 83829,
        "last_week": 725931,
        "total": 113721220
      }
    },
    {
      "faction_id": 500010,
      "pilots": 41,
      "systems_controlled": 0,
      "kills": {
        "yesterday": 544,
        "last_week": 544,
        "total": 544
      },
      "victory_points": {
        "yesterday": 0,
        "last_week": 0,
        "total": 0
      }
    },
    {
      "faction_id": 500011,
      "pilots": 242,
      "systems_controlled": 0,
      "kills": {
        "yesterday": 1667,
        "last_week": 1667,
        "total": 1667
      },
      "victory_points": {
        "yesterday": 0,
        "last_week": 0,
        "total": 0
      }
    }
  ],
  "sentry_id": "a4b736b268d64743b79ff2c0d9af9e68"
}

Expected

HTTP 200, This is obviously working internally but the esi ?wrapper? is confused due to the additional wars being returned.

Checklist

Check all boxes that apply to this issue:

soratidus999 commented 10 months ago

i''ve just seen the stats and leaderboard endpoints endpoints all expire at 1105, (I thought only leaderboard was refreshed daily)

Awaiting tomorrows results

soratidus999 commented 10 months ago

as of downtime this is now echoing the Invalid 200 response: too many items for 'response', now that it has had a day to update the stats

gitAskur commented 10 months ago

Should be good now. Thanks for the patience.