esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
208 stars 23 forks source link

Add context_id to transaction_tax & brokers_fee type journal entries #1369

Open SefaOray opened 10 months ago

SefaOray commented 10 months ago

Feature Request

It would be great to keep track of transaction_tax & brokers_fee per market order.

Use case

I would like to gain better insights into my production and trading transactions. Transactions tax changes based on unit price and I pay additional brokers fee when I adjust my order, which makes profit calculations very tricky.

Linking transaction_tax & brokers_fee journal entries to market orders would bring more transparency into my expenses and I can calculate more accurate expenses table for a certain trade or production project.

Authentication

Existing scope: esi-wallet.read_character_wallet.v1

Example return

Propose what an example return might look like. E.g.:

[
  {
    "amount": -3072049.27,
    "balance": 1402505658.9042,
    "date": "2023-11-29T12:15:07Z",
    "description": "Market order commission to broker authorized by: Redacted",
    "first_party_id": "CharacterId",
    "id": 9876564321,
    "reason": "",
    "ref_type": "brokers_fee",
    "second_party_id": 1000035,
    "context_id": 123456,
    "context_id_type": "market_transaction_id",
  }
]

Checklist

Check all boxes that apply to this issue: