esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
209 stars 23 forks source link

Date formats inconsistent #1373

Closed guiguilechat closed 5 months ago

guiguilechat commented 9 months ago

Inconsistency

date format are inconsistent among paths and headers

For an example, let's look at https://esi.evetech.net/latest/markets/10000002/orders/?datasource=tranquility&order_type=all and its specification https://esi.evetech.net/ui/#/Market/get_markets_region_id_orders

Routes

basically all that return a response with a date.

Resolution

add the format of the date in the documentation, like "issued in iso8601 date time format" instead of "issued string"

Checklist

Check all boxes that apply to this issue:

guiguilechat commented 9 months ago

Another date format is the date field of https://esi.evetech.net/ui/#/Market/get_markets_region_id_history Which is a day.

steven-noorbergen commented 5 months ago

As far as I see it you're comparing HTTP headers with OpenAPI json-serialized data, which is two different beasts altogether.

In general, dates and datetimes are serialized using iso8601 in the JSON output, this can be seen in endpoints like https://esi.evetech.net/ui/#/Character/get_characters_character_id, https://esi.evetech.net/ui/#/Corporation/get_corporations_corporation_id and https://esi.evetech.net/ui/#/Alliance/get_alliances_alliance_id (Taking these since they are public so easier to verify).