soratidus999 commented 2 weeks ago

Bug

Regression of https://github.com/esi/esi-issues/issues/1368

Some notifications returned from /characters/{character_id}/notifications/ are not returning their type, instead they are returning an "unknown notification type (280)" breaking validation of this response data. Interfering with the normal usage of this endpoint.

This is occuring because the respective notification types have not been added to eve-glue, https://github.com/esi/eve-glue/pull/35 is pending review and merge

Request

GET http://characters/character_id/notifications/?datasource=tranquility

Response

Status Code

200

Headers

I didnt record headers this time around

Body

...
  {
    "notification_id": 1234567890,
    "sender_id": 1234567890,
    "sender_type": "character",
    "text": "corpID: 1234567890\n",
    "timestamp": "2024-06-17Txx:yy:00Z",
    "type": "unknown notification type (280)"
  },
...

Expected

200

...
  {
    "notification_id": 1234567890,
    "sender_id": 1234567890,
    "sender_type": "character",
    "text": "corpID: 1234567890\n",
    "timestamp": "2024-06-17Txx:yy:00Z",
    "type": "SkinSequencingCompleted"
  },
...

Checklist

Check all boxes that apply to this issue:

[x] Bug description is provided
[x] Request path is provided
[x] Response status code is provided
[ ] Response headers are provided
[x] Response body is provided
[x] Expected response is provided

soratidus999 commented 5 days ago

unknown notification type (283) introduced by PATCH NOTES FOR 2024-07-04.1

soratidus999 commented 2 days ago

unknown notification type (6040) Is being passed to ESI, not sure if this is new but we've only just noticed it

I thought these were supposed to be be persistent notifications, so i have no followed up these on eve-glue

esi / esi-issues

/characters/{character_id}/notifications/ - unknown notification type (280) #1380

Bug