soratidus999 commented 3 months ago

Bug

Some assets returned from /characters/{character_id}/assets/ are not returning their location_flag, instead they are returning an "unknown location_flag (185)" breaking validation of this response data. Interfering with the normal usage of this endpoint.

This is occuring because the respective location flags have not been added to eve-glue, https://github.com/esi/eve-glue/pull/35 is pending review and merge

Request

GET http://characters/character_id/notifications/?datasource=tranquility

Response

Status Code

200

Headers

Logging this issue on behalf of others, I dont have these new ships

Body

[
  {
    "is_singleton": false,
    "item_id": 123456789,
    "location_flag": "unknown location_flag (185)",
    "location_id": 1234567879,
    "location_type": "item",
    "quantity": 1,
    "type_id": 32458
  },
  ...

Expected

[
  {
    "is_singleton": false,
    "item_id": 123456789,
    "location_flag": "InfrastructureHangar",
    "location_id": 1234567879,
    "location_type": "item",
    "quantity": 1,
    "type_id": 32458
  },
  ...

Checklist

Check all boxes that apply to this issue:

[x] Bug description is provided
[x] Request path is provided
[x] Response status code is provided
[ ] Response headers are provided
[x] Response body is provided
[x] Expected response is provided

pvyParts commented 3 months ago

I'm also seeing now "unknown location_flag (186)" on the corporate asset endpoints.

soratidus999 commented 2 months ago

/v5/characters/{character_id}/assets/ and /v5/corporations/{corporation_id}/assets/

Addresses these locations for both Character and Corporation Assets

esi / esi-issues

/characters/{character_id}/assets/ - 'unknown location_flag (185)' #1381

Bug