Bug

Some notifications returned from /characters/{character_id}/notifications/ are not returning their type, instead they are returning an "unknown notification type (264)" breaking json validation of this response data. Interfering with the normal usage of this endpoint.

likely because they are missing in https://github.com/esi/eve-glue/blob/master/eve_glue/notification_type.py

This Notification lines up in the existing 260 range with Corporation Projects, it is assumed to be Corporation Project Expired

Request

GET http://characters/character_id/notifications/?datasource=tranquility

Response

Status Code

200

Headers

Intentially Left Blank

Body

...
  {
    "notification_id": 1234567890,
    "sender_id": 1234567890,
    "sender_type": "character",
    "text": "corpID: 1234567890\n",
    "timestamp": "2024-11-28Txx:yy:00Z",
    "type": "unknown notification type (264)"
  },
...

Expected

200

...
  {
    "notification_id": 1234567890,
    "sender_id": 1234567890,
    "sender_type": "character",
    "text": "corpID: 1234567890\n",
    "timestamp": "2024-12-02T00:00:00Z",
    "type": Something valid from https://github.com/esi/eve-glue/blob/master/eve_glue/notification_type.py
  },
...

Checklist

Check all boxes that apply to this issue:

[x] Bug description is provided
[x] Request path is provided
[x] Response status code is provided
[ ] Response headers are provided
[x] Response body is provided
[x] Expected response is provided

esi / esi-issues

/characters/{character_id}/notifications/ - unknown notification type (264) #1401

Bug