search

esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
207 stars 23 forks source link

War information for Alliances & Corporations #305

Open jowrjowr opened 7 years ago

jowrjowr commented 7 years ago

Currently there's no way to determine, via API, whether a given alliance or corporation is at war except by parsing literally the entire war endpoint. Which is "not ideal".

What I would like to see is something like this in the json return from /corporations and /alliances:

{ war_id: 123123123 }

From there I can query the war endpoint directly and get more detailed war information.

No war_id? No war.

gitAskur commented 7 years ago

Mental Note: This has to be alliance AND corp, not just corp and then a separate one for alliances because any corp in an alliance will always be registered into that as the alliance and not the corp. This is not biggie as all the tech supports this but I just did a bad last Friday and this is a mental note for addressing that tomorrow on Tuesday the 13th. A specter is haunting Europe.

SpeedProg commented 6 years ago

Damn, dreams shattered :(

gordonzero commented 6 years ago

For the love of god make this a thing ... otherwise i have to pull the entire war record dating back 3 weeks on my app to verify their are no wars for a corp

gitAskur commented 6 years ago

I am terrible with closing these issues or assigning them elsewhere!

Pretty sure I addressed this in the monolith a long time ago and such.. let me look over code and my submit history.

gitAskur commented 6 years ago

There's totally changes to factor in alliance membership for corps, on the 20th of June.

gitAskur commented 6 years ago

All monolith side stuff seems on the up and up for this but I can't find an ESI action using this, nor is it on the current XML Parity list. At least I can not find it there, if it is there under some weird ass name just point it out to me and it becomes a part of parity.

It does seem like a very sensible endpoint to have, but we're kind of in a wholly committed relationship with finishing the parity right now so I can't promise it will get done-done until we're done-done-done with parity.

@aquarhead @ccp-zoetrope @tsuthers-ccpgames - I am unassigning this from me because I'm focusing on the actions for now and shouldn't be pretending to be addressing this.

antihax commented 6 years ago

This could be combined with #152 as a filter parameter to the existing wars endpoint? Allowing it to be filtered by an entityID, either corp or alliance.