esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
209 stars 23 forks source link

Feature request: Contracts BPC/BPO #407

Closed GoldenGnu closed 6 years ago

GoldenGnu commented 7 years ago

Feature request

Route

/characters/{character_id}/contracts/ /corporations/{corporation_id}/contracts/

Use case

I would like to be able to identify blueprint copies and originals in ESI once the contracts endpoint is completed. Should work just like the quantity in the assets ESI endpoint

Example returns

quantity: -2 = BPC (Blueprint Copy) quantity: -1 = BPO (Blueprint Original) quantity: 2 = BPO (Blueprint Original)

quantity: 1 = Should never be used for blueprints, use -1 for BPO and -2 for BPC quantity: 0 = Should never be used for anything

Previous XML or CREST route

ContractItems in the XML API

a-tal commented 7 years ago

does this use the same conventions as killmails?

GoldenGnu commented 7 years ago

I do not know that, I have never used the killmails API...

GoldenGnu commented 7 years ago

It does not have to use the quantity like assets. Any way you like to do it is fine by me. As long as it's possible to identify both BPO and BPC, I'm a happy man :)

ddavaham commented 7 years ago

@GoldenGnu I do not understand why this is even an issue on here. The Contracts Endpoint will likely be identical to the XML Contracts Endpoint. The same conventions will be used that were used on the XML Endpoint and the XML Endpoint uses exactly what you just outlines above.

XML API ContractItems Documentation

GoldenGnu commented 7 years ago

To the best of my knowledge rawQuantity never actually worked in the ContractItems XML API. Last I check, and I admit that is a while ago, rawQuantity was never returned by the XML API. So, I just wanted to make sure it was included in ESI and working...

CarbonAlabel commented 6 years ago

Closing in favour of https://github.com/esi/esi-issues/issues/827.