search

esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
208 stars 23 forks source link

location_flag inconsistency between ESI and SDE #568

Open GoldenGnu opened 7 years ago

GoldenGnu commented 7 years ago

Inconsistency

Routes

https://esi.tech.ccp.is/latest/#!/Assets/get_characters_character_id_assets https://esi.tech.ccp.is/latest/#!/Assets/get_corporations_corporation_id_assets https://esi.tech.ccp.is/latest/#!/Character/get_characters_character_id_blueprints https://esi.tech.ccp.is/latest/#!/Corporation/get_corporations_corporation_id_blueprints

Description

1) The following location_flag enum names does not match the flag values in the SDE

ESI               SDE
CorpDeliveries    CorpMarket
Impounded         OfficeImpound
ServiceSlot0      StructureServiceSlot0
ServiceSlot1      StructureServiceSlot1
ServiceSlot2      StructureServiceSlot2
ServiceSlot3      StructureServiceSlot3
ServiceSlot4      StructureServiceSlot4
ServiceSlot5      StructureServiceSlot5
ServiceSlot6      StructureServiceSlot6
ServiceSlot7      StructureServiceSlot7

Note: I'm not sure CorpDeliveries and Impounded are matched correctly to the SDE flags

2) The following location_flag enum values are not in the SDE

AutoFit
Module
CorpseBay
HangarAll
DustDatabank
DustBattle
HiddenModifers

Resolution

1) Use the SDE values in ESI or vice versa 2) Added the missing flag values to the SDE

lhkbob commented 7 years ago

It would also be nice if the enums for these routes would be the same, or at least the same within the character and corporation classes. Currently in ESI, the corporation blueprint location flag and asset location flags are equivalent. However, the character blueprint location flag is missing the "Wardrobe" and "SubSystemBay" values compared to the character asset location flag.

It makes sense for the corporation location flag to be a superset of the character location flag since it includes all of the corporation storage options not accessible to a single character. However, the character location flag includes the "CorpseBay" value, which could just as well be included in the corporation location flags (I think), in which case the superset relationship is preserved. Right now they are overlapping but the corporation location flag enum does not contain the character enum.

These changes would only be nice-to-haves from a type generation perspective. Right now it requires three separate type declarations to cover these enums, when it should be doable in two.

GoldenGnu commented 7 years ago

Character blueprints v3 will be released 2017-10-06 (it’s currently in dev) and it have a better location_flag.

Edit: Turns out I was thinking of the Character Journal V2 (Released on the same date and have updated RefTypeEnum) Character blueprints v3 just have x-pages

Khazl commented 6 years ago

Are there any documentation for this new location flags? I found an asset from type blueprint with the location flag "AutoFit"?