search

esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
209 stars 23 forks source link

contract items argument order is inconsistent with itself. #699

Closed jennej closed 6 years ago

jennej commented 6 years ago

ATTENTION: DON'T SUBMIT SSO/CREST/XML RELATED ISSUES

Inconsistency

Routes

/corporations/{corporation_id}/contracts/{contract_id}/items/ /characters/{character_id}/contracts/{contract_id}/items/

Description

The order that the parameters to these two routes are declared in the swagger code is swapped.
corps is contract_id then corporation_id chars is character_id then contract_id

this means that any generated api code, is going to put those args in that order, which, since they are both id's, was a bit of a debugging mess. It was easy enough to sort out, but it still makes me twitch a bit.

Resolution

Pick an order?

a-tal commented 6 years ago

parameters are alpha sorted by name