esi / esi-issues

Issue tracking and feature requests for ESI
https://esi.evetech.net/
209 stars 23 forks source link

Feature request: Reduce wallet/journal/ cache time #829

Open jbs1 opened 6 years ago

jbs1 commented 6 years ago

Feature request

Reduce cache time for journal endpoint

Route

/characters/{character_id}/wallet/journal/

Use case

Twitch streamers use these overlay alerts for donations and things like that. I wanted to create such an overlay for isk donations, mostly because of friend who streams asked me. But I assume the community of twitch streamers would also have a use of that. Given that we will never get the ability to send ISK through esi, continually pulling wallet journals to check for donations is the next best thing.

But puling it once an hour is pretty useless. Once a minute or every two minutes or so would be much more useful.

SpeedProg commented 6 years ago

I want this too, for reasons I'd rather not disclose through :>

jbs1 commented 6 years ago

There is another option if you don't want to do that, Because it can be a lot of data to be returned. The other option would be to create another endpoint that would return only journal entry of the last 5 min or the last 15 entries or so. But for that we should be able to hit the endpoint every 10 seconds or so. Call it '/characters/{character_id}/wallet/journal/recent/' or something

Aidansavage commented 6 years ago

That's as unlikely to happen as a massive cache reduction IMO. It just duplicates information, which TechCo's been vehemently murdering when they find it (if any of it exists still).

CarbonAlabel commented 6 years ago

I've already asked for this in #546. The current cache time of 60 minutes is actually a regression from the XML API, which offered the information on a 30 minute cache time, and ESI should do even better than that.

E-351 commented 5 years ago

I'd love to see this together with related routes reduced to at least 30 or better 20 minutes (so it matches https://esi.evetech.net/ui/#/Market/get_characters_character_id_orders ). An hour is just really painful to work with for basically anything.

https://esi.evetech.net/ui/#/Wallet/get_corporations_corporation_id_wallets_division_journal https://esi.evetech.net/ui/#/Wallet/get_corporations_corporation_id_wallets_division_transactions https://esi.evetech.net/ui/#/Wallet/get_characters_character_id_wallet_journal https://esi.evetech.net/ui/#/Wallet/get_characters_character_id_wallet_transactions

E-351 commented 5 years ago

My use case: Grouping transactions into "projects" and tracking their profitability. User now must wait up to an hour to be able to put transactions into correct projects which can make it somewhat difficult to remember what belongs where.

Would perhaps an option to limit results to some time period help with the call cost?

jbs1 commented 5 years ago

I mean the results are already limited due to Pagination. So results are limited to like 1000 entries per call or something. But the point still stands. 1 hour cache make that endpoint practically unusable for most use cases.