search

esig / dss-demonstrations

Examples of DSS integration
GNU Lesser General Public License v2.1
92 stars 70 forks source link

Verify maven build #16

Closed ioggstream closed 1 year ago

ioggstream commented 3 years ago

This PR

Build the project with maven to ensure the project builds correctly at every pull request.

bsanchezb commented 1 year ago

Hello,

The automatic build is not very important for the demonstrations project, especially that the test cases here mainly test not DSS itself, but its "enveloper" such as spring, or use integration-tests requiring spring running.

Best regards, Aleksandr.

ioggstream commented 1 year ago

Without an automatic build, how do you ensure that the project actually builds?

bsanchezb commented 1 year ago

You can execute "mvn clean install" locally. The problem here is that even that command is not enough to ensure the project works as expected, without actual running the standalone app or the spring application. Therefore, this automatic build I find redundant, as you will have to test the project locally in any case whatever GitHub's build succeeds or not.

I hope this clarifies.

Regards, Aleksandr.

ioggstream commented 1 year ago

Hi Alexandr, and thanks for your time and replies!

not enough to ensure that the project works as expected

IMHO, that is true for every project, since quality processes are always partial (i.e., they only test a subset of the properties/features of a product).

OTOH, a bit of quality process is still better than no quality process, because once I have such a process, it can be improved (e.g., adding further tests).

I think this project is important because many agencies rely on esig, and I suspect that even some of the dss-demonstrations code is reused into production code across :eu:. This is because agencies trust the maintainers of all of the esig repos.

While every organization is clearly responsible of the code it reuses, I feel that it is advisable for EU project to consider the (intended or unintended) impacts of its digital products in the field of cybersecurity and trust services.

Kind regards, R.