esign / laravel-conversions-api

A laravel wrapper package around the Facebook Conversions API
MIT License
53 stars 11 forks source link

Change instructions about ConversionsApi::setUserData in the readMe to use a middleware #5

Closed QuentinGab closed 1 year ago

QuentinGab commented 1 year ago

Omschrijving

The readme stated to add ConversionsApi::setUserData in AppServiceProvider boot method but it actually do nothing because the session in not yet initialized in AppServiceProvider, so auth()->user() will always be null.

I suggest to put ConversionsApi::setUserData in a middleware.

Type aanpassing

Testen

No test changed or new test needed.

Checklist:

Vervolledig de checklist & verwijder opties die niet relevant zijn.

jordyvanderhaegen commented 1 year ago

Thanks!