search

esimov / pigo

Fast face detection, pupil/eyes localization and facial landmark points detection library in pure Go.
MIT License
4.37k stars 309 forks source link

NewPigo + Unpack overhead? #21

Closed cgxeiji closed 4 years ago

cgxeiji commented 5 years ago

I was wondering why func Unpack() (*Pigo, error) needs to be a method of the struct Pigo if that struct is never used inside the method. I think making Unpack() a method of the package, instead of the struct, would have less overhead when initializing the classifier.

What do you think?