esimov / pigo

Fast face detection, pupil/eyes localization and facial landmark points detection library in pure Go.
MIT License
4.39k stars 310 forks source link

On the CLI, -flpc flag doesn't work without -plc. #59

Closed SystemR closed 2 years ago

SystemR commented 2 years ago

Describe the bug

-fplc flag doesn't seem to work if -plc isn't specified.

This command works fine: $ pigo -in image.jpg -out output.jpg -cf ../pigo/cascade/facefinder -plc ../pigo/cascade/puploc -flpc ../pigo/cascade/lps

But running the following only detects the face but not its facial landmarks: $ pigo -in image.jpg -out output.jpg -cf ../pigo/cascade/facefinder -flpc ../pigo/cascade/lps

Expected behavior

-flpc should work without -plc as per the screenshot https://user-images.githubusercontent.com/883386/66802771-3b0cc880-ef26-11e9-9ee3-7e9e981ef3f7.png

esimov commented 2 years ago

@SystemR thank you for the notification about this issue. This should be fixed now.

SystemR commented 2 years ago

Thank you! Would this be in 1.4.6?

esimov commented 2 years ago

Yes, I'm planning to rollout the fixes as a new release. Meantime these are available as the latest version.

SystemR commented 2 years ago

Perfect! Thank you so much! We can close this issue I guess.

esimov commented 2 years ago

The new release has been published, so I'm closing this ticket.