esitarski / CrossMgr

Cyclo Cross Management Application
MIT License
40 stars 20 forks source link

Tags with leading 0 not loaded from excel correctly #120

Closed jezza323 closed 1 year ago

jezza323 commented 1 year ago

Tags with a leading 0 in the linked excel sheet don't load into CrossMgr with the leading zero

Have tried

0xxxxxxx '0xxxxxxx Formatted as text in excel

Same result for all

Submitting tags via webreader does accept/process as a leading zero as expected.

Tags in the unmatched excel match exactly those in the linked spreadsheet

Any tips to resolve?

esitarski commented 1 year ago

CrossMgr strips leading zeros to be compatible with Excel behavior, which also strips leading zeros from numeric input. As many people flow numeric tags in and out of Excel, and humans often skip leading zeros when repeating numbers, this led to many bugs as a result of integration issues. Best practice is not to use tags with leading zeros.

On Sun, Apr 30, 2023 at 7:30 AM jezza323 @.***> wrote:

I am using a custom reader and submitting raw epcs in hex format as my tags. Tags with a leading 0 in the linked excel sheet don't load into CrossMgr with the leading zero

Have tried

0xxxxxxx '0xxxxxxx Formatted as text in excel

Same result for all

Submitting tags via webreader does accept/process as a leading zero as expected

Any tips to resolve?

— Reply to this email directly, view it on GitHub https://github.com/esitarski/CrossMgr/issues/120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGXKM2FNEKBSPXRCFZDNLXDZEMHANCNFSM6AAAAAAXQ3RDUA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Edward Sitarski

jezza323 commented 1 year ago

Thanks for the confirmation. Not my tags unfortunately! I will modify my custom reader to strip leading zeros also instead 👍

esitarski commented 1 year ago

Recognized that this is a pain, but sooo many times all-digit hex tags when in-and-out of Excel and had the leading zeros deleted. Check that you don't have insanity where the number of leading zeros is significant (eg. 000ABC, 00ABC).

On Sun, Apr 30, 2023 at 8:02 AM jezza323 @.***> wrote:

Closed #120 https://github.com/esitarski/CrossMgr/issues/120 as completed.

— Reply to this email directly, view it on GitHub https://github.com/esitarski/CrossMgr/issues/120#event-9132177363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGXKPA7HF7UM3YGLGRYOTXDZIF5ANCNFSM6AAAAAAXQ3RDUA . You are receiving this because you commented.Message ID: @.***>

--

Edward Sitarski