search

esitarski / CrossMgr

Cyclo Cross Management Application
MIT License
40 stars 20 forks source link

Pyinstaller 6.0.0 will break additional file locations #124

Closed kimble4 closed 10 months ago

kimble4 commented 10 months ago

Just a headsup that last week's release of Pyinstaller 6.0.0 has changed where the built executable looks for additional resources using __file__. (At least under Windows, but it sounds like it applies to MacOS too.)

I haven't (yet) managed to work out exactly what needs changing in the CrossMgr build process to ensure that the icons/html/etc. end up in the new _internal sub-directory. You'll see the problem next time you do a dev build.

https://pyinstaller.org/en/latest/CHANGES.html#incompatible-changes refers

kimble4 commented 10 months ago

Looks like setting $resourcedir = "dist/$program/_internal" in compile.ps1 is a workaround for the Windows build, though that doesn't seem like a very Pyinstaller way to do it. The correct approach probably involves the --add-data option.

kimble4 commented 10 months ago

Now resolved.