search

esitarski / CrossMgr

Cyclo Cross Management Application
MIT License
41 stars 21 forks source link

CrossMgr does not seem to be able to import Impinj data file saved from CrossMgrImpinj #52

Closed mbuckaway closed 4 years ago

mbuckaway commented 4 years ago

Describe the bug A rider decided to jump into a race without registering on advise of the race organizer, and I found out while the race was running. Bla, bla, bla, shoot the race organizer, etc.. Turns on the rider placed in the top five. Ug. Didn't think to add her into the Excel sheet while the race was running. Attempting to fix the race after the fact and generate an updated set of results. However, got an error about time format importing the Impinj Data file.The message does not indicate if the error is in the dialog box entry field for time or in the data itself, and I dont have time at the moment to search the code.

To Reproduce Steps to reproduce the behavior:

  1. Create a new race.
  2. Link the Excel file generated by RaceDB from the race to the newly created race.
  3. Confirm the race filename will change.
  4. Click on Chip Reader->Import Impinj file
  5. Fill in the dialog as per the attached image.
  6. Click ok, get the attached error.
  7. Import say it work, but no data appears in the race.

Expected behavior Race would be populated with race data, passing, etc..

Screenshots Screen Shot 2020-02-02 at 9 49 56 PM Screen Shot 2020-02-02 at 9 50 04 PM Screen Shot 2020-02-02 at 9 50 10 PM

Desktop (please complete the following information):

Additional context grepping the code base did not find the error or any related text. Probably in a language file. Not sure if this is a problem between the keyboard and the chair or an actually bug. Files are attached. The question is, is this an issue of the dialog box reporting an invalid time in the dialog, or the ImpinjData file?

Impinj-2020-02-01-14-11-26.txt DummyRace.xlsx

esitarski commented 4 years ago

OK. I will look at the files. There is a much easier way to fix this - just add the rider to the Excel sheet. That's it. No need to import from the Impinj file. CrossMgr stores all chip reads internally and will match them to an updated Excel sheet to fix the results.

On Sun, Feb 2, 2020 at 10:14 PM Mark Buckaway notifications@github.com wrote:

Describe the bug A rider decided to jump into a race without registering on advise of the race organizer, and I found out while the race was running. Bla, bla, bla, shoot the race organizer, etc.. Turns on the rider placed in the top five. Ug. Didn't think to add her into the Excel sheet while the race was running. Attempting to fix the race after the fact and generate an updated set of results. However, got an error about time format importing the Impinj Data file.The message does not indicate if the error is in the dialog box entry field for time or in the data itself, and I dont have time at the moment to search the code.

To Reproduce Steps to reproduce the behavior:

  1. Create a new race.
  2. Link the Excel file generated by RaceDB from the race to the newly created race.
  3. Confirm the race filename will change.
  4. Click on Chip Reader->Import Impinj file
  5. Fill in the dialog as per the attached image.
  6. Click ok, get the attached error.
  7. Import say it work, but no data appears in the race.

Expected behavior Race would be populated with race data, passing, etc..

Screenshots [image: Screen Shot 2020-02-02 at 9 49 56 PM] https://user-images.githubusercontent.com/13733422/73622892-d1b1e200-4608-11ea-82cf-2edba738213f.png [image: Screen Shot 2020-02-02 at 9 50 04 PM] https://user-images.githubusercontent.com/13733422/73622906-e5f5df00-4608-11ea-9426-fdc48e5ae563.png [image: Screen Shot 2020-02-02 at 9 50 10 PM] https://user-images.githubusercontent.com/13733422/73622910-e8583900-4608-11ea-9bf9-71630f89a7d3.png

Desktop (please complete the following information):

  • OS: CrossMgrImpinj on Linux was used to collect the data, but CrossMgr on Mac was use to attempt to redo the race
  • Version : Current dev release (3.0.46-beta)

Additional context grepping the code base did not find the error or any related text. Probably in a language file. Not sure if this is a problem between the keyboard and the chair or an actually bug. Files are attached. The question is, is this an issue of the dialog box reporting an invalid time in the dialog, or the ImpinjData file?

Impinj-2020-02-01-14-11-26.txt https://github.com/esitarski/CrossMgr/files/4146095/Impinj-2020-02-01-14-11-26.txt DummyRace.xlsx https://github.com/esitarski/CrossMgr/files/4146097/DummyRace.xlsx

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/esitarski/CrossMgr/issues/52?email_source=notifications&email_token=AABGXKMGO7IU2DTRTEYCJLTRA6D2RA5CNFSM4KO6FZWKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IKO3BFA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGXKPLOAQUZRCWAUKJR2DRA6D2RANCNFSM4KO6FZWA .

--

Edward Sitarski

rkantos commented 4 years ago

This problem comes from my pull request to the dev-branch. https://github.com/esitarski/CrossMgr/pull/47 Importing should work normally on the master-branch... I concur what @esitarski said. All chip passings will be in CrossMgr, if they were successfully transferred over by CrossMgrImpinj, therefore you should be able to just add the participant. I've done it before by updating the race in RaceDB, and the reopening the race from File -> Open From RaceDB server... I'm not sure, but I think that is almost the same as adding the participant on the Excel sheet.

I will make another pr soon fixing my pr. You can also revert it.

mbuckaway commented 4 years ago

My first thought was to add the rider to the excel linked spreadsheet. So, I pulled her data from another race excel including the tag number and inserted into the race. I saved the excel sheet, and looked at CrossMgr. Nothing. I expected the missing rider to show up in the results. That never happened. So, I went back to recreating the race from the impinj data.

I would have looked into it, but 10PM at night after being at a race all weekend, the only thing I wanted was to update the results, and put the race to bed (and myself).

What I don't know is how the changes to the excel sheet are tracked...and if that is windows only code.

mbuckaway commented 4 years ago

As the release version working and the dev one not, I just proofed WHY we work on dev branch and do testing before a release.

esitarski commented 4 years ago

Did you check that the rider's bib number was included in the Category range?

On Tue, Feb 4, 2020 at 8:24 AM Mark Buckaway notifications@github.com wrote:

As the release version working and the dev one not, I just proofed WHY we work on dev branch and do testing before a release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/esitarski/CrossMgr/issues/52?email_source=notifications&email_token=AABGXKNOUT53IGALMFRZFSLRBFT7DA5CNFSM4KO6FZWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKXTJAQ#issuecomment-581907586, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGXKKFYRFE2LEP2JA7SWTRBFT7DANCNFSM4KO6FZWA .

--

Edward Sitarski

mbuckaway commented 4 years ago

Yes. Assigned her a new number for the cat in RaceDB, and used that.

mbuckaway commented 4 years ago

All the race files are here: FCV Xtreme Track Race

mbuckaway commented 4 years ago

So, it would appear when racedb creates the race, it create categories with a number limit for categories with only numbers that exist in a race and not the number range setup in racedb. So, when I looked at the category range, it was up to 63 and not the 64 of the number I assigned. So, changed that to 64 and the rider appeared. World saved.

However, there still is some issue with the import dialog which was the original reported problem.

esitarski commented 4 years ago

Correct. RaceDB creates a minimal category number range (probably should look at this given that it knows the category ranges). Yes there was a bug with the import. I just fixed it, but encountered a git checkin error which I don't understand.

On Tue, Feb 4, 2020 at 11:15 AM Mark Buckaway notifications@github.com wrote:

So, it would appear when racedb creates the race, it create categories with a number limit for categories with only numbers that exist in a race and not the number range setup in racedb. So, when I looked at the category range, it was up to 63 and not the 64 of the number I assigned. So, changed that to 64 and the rider appeared. World saved.

However, there still is some issue with the import dialog which was the original reported problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/esitarski/CrossMgr/issues/52?email_source=notifications&email_token=AABGXKMTBORDXOEFBBDK4ITRBGICFA5CNFSM4KO6FZWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKYG2PA#issuecomment-581987644, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGXKNSQAC73FJVJS34MJDRBGICFANCNFSM4KO6FZWA .

--

Edward Sitarski

esitarski commented 4 years ago

Github issues addressed. Fixes to import dialog are checked in on dev branch.