Closed cjmcqueen closed 1 year ago
Does seem to be an issue with dark mode enabled for the UI on MacOS. Disabling dark mode and using light mode could be a workaround.
Oddly enough, turning the global UI setting back to dark enables readable UI... So, the work around is turn it on and off? 🤷🏻♂️
Unfortunately I am not a Mac expert. I will bring up the issue of support for Mac dark mode to the latest Mac contributor. Internally, CrossMgrImpinj does not set the foreground text color and is picking it up from Mac OS.
Clearly, this isn't working well. I suspect the fix will be to go through every interface where it isn't working, then programmatically setting colors that work if dark mode is enabled.
On Sat, Nov 13, 2021 at 9:00 PM Chris McQueen @.***> wrote:
Oddly enough, turning the global UI setting back to dark enables readable UI... So, the work around is turn it on and off? 🤷🏻♂️
[image: image] https://user-images.githubusercontent.com/128125/141664557-e1016f0b-4b7a-4722-8b51-490307422fb7.png
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/esitarski/CrossMgr/issues/84#issuecomment-968190544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGXKJ7VMY5AOSH7XLR3E3UL4J2BANCNFSM5H7IZ4EQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
--
Edward Sitarski
I removed some overrides so that the colours follow the defaults better. I also added a check for dark mode so that the text color is set to black when CrossMgrImpinj changes the background. Hopefully this should work better in dark mode.
On Mon, Nov 15, 2021 at 10:17 AM Edward Sitarski @.***> wrote:
Unfortunately I am not a Mac expert. I will bring up the issue of support for Mac dark mode to the latest Mac contributor. Internally, CrossMgrImpinj does not set the foreground text color and is picking it up from Mac OS.
Clearly, this isn't working well. I suspect the fix will be to go through every interface where it isn't working, then programmatically setting colors that work if dark mode is enabled.
On Sat, Nov 13, 2021 at 9:00 PM Chris McQueen @.***> wrote:
Oddly enough, turning the global UI setting back to dark enables readable UI... So, the work around is turn it on and off? 🤷🏻♂️
[image: image] https://user-images.githubusercontent.com/128125/141664557-e1016f0b-4b7a-4722-8b51-490307422fb7.png
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/esitarski/CrossMgr/issues/84#issuecomment-968190544, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGXKJ7VMY5AOSH7XLR3E3UL4J2BANCNFSM5H7IZ4EQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
--
Edward Sitarski
--
Edward Sitarski
Is this issue resolved? Is so, can you close it?
Issue assumed to be fixed. Reopen if it isn't.
Describe the bug It's difficult to read the text of the app on MacOS. Could be especially difficult on site with sun on the screen.
To Reproduce Steps to reproduce the behavior: Open app
Expected behavior The background and text would be higher contrast.
Screenshots
Desktop (please complete the following information):