esjeon / krohnkite

A dynamic tiling extension for KWin
MIT License
1.66k stars 66 forks source link

Focus Left/Right not working #135

Open rronsh opened 3 years ago

rronsh commented 3 years ago

Symptom Meta+H and Meta+L (Krohnkite: Left: and Krohnkite: Right:) shortcuts dont work as they should. Instead of moving focus left right they resize the window left/right

How to Reproduce Press the shortcuts. Rebinding doesnt help.

Expected behavior I expect the focus to change, instead the windows are resized

Environment

esjeon commented 3 years ago

This is because the default "behavior" is DWM mode. This can be changed in Krohnkite settings on KWin Scripts dialog.

But, yeah, having this kind of "mode" inside is very confusing. I'll have to remove this thing...

rronsh commented 3 years ago

Oh thanks somehow i completely missed that part of the config, so my bad really.

Probably just changing the default mode to be directional instead of DWM would be the better solution. Or at least somehow highlight/explain the behaviour in the keybinds section of the README as the current descriptions of "Left" and "Right" are a bit confusing. Maybe do the same name change for the Keybinds section. This way it would also be more consistent with how Up and Down are labeled.

Suggested change to README:

now:
META-H Left
META-L Right
after:
META-H Focus/Adjust Left *
META-L Focus/Adjust Right *

*See configuration under Behaviour: Directional vs. DWM

nigelwarning commented 3 years ago

This is because the default "behavior" is DWM mode. This can be changed in Krohnkite settings on KWin Scripts dialog.

But, yeah, having this kind of "mode" inside is very confusing. I'll have to remove this thing...

Hope you don't mean you will remove 'focus mode' Because I really love that mode. Coming from BSPWM, focus mode for me is more logical then the DWM mode