search

esjeon / krohnkite

A dynamic tiling extension for KWin
MIT License
1.62k stars 60 forks source link

in v. 0.8.1 config button no longer visible after update #200

Closed dennisMe2 closed 2 years ago

dennisMe2 commented 2 years ago

Symptom after update to version 0.8.1 config button is gone. Deselecting, clicking apply and re selecting krohnkite does not restore it. The symlink mentioned in the docs is present and has user / default user group permissions. Krohnkite itself still works. Removing the script, deleting the symlink and restoring the script does not work, even manually removing and re creating the symlink does not work, the link points to a valid target.

How to Reproduce I use Kubuntu and installed the update via the regular update manager.

Expected behavior The config button should not have disappeared and should have at least re-appeared after disabling / enabling the script.

Environment

Notes The script is really handy, thanks a lot for putting in the effort!

FredNov commented 2 years ago

confirm. No settings button anymore

Environment

GandertM commented 2 years ago

Confirmed. No settings button anymore

Environment

esjeon commented 2 years ago

FYI, I'm on 5.24.0 and the script works only with v0.8.1. It seems like KWin changed the behavior abruptly.

From a related bug ticket on the KDE side: https://bugs.kde.org/show_bug.cgi?id=444378 :

Putting X-KDE-ConfigModule=kwin/effects/configs/kcm_kwin4_genericscripted in metadata.desktop indeed solves the problem for Plasma 5.24.0. However, I then get the “Plugin does not provide configuration file in expected location” error message on Plasma 5.23.5 when clicking the config button

Hmm, I think I'll just revert the version back to 0.8, and release 0.8.1 separately.

dennisMe2 commented 2 years ago

Is there no way of sniffing out the plasma version from code?

esjeon commented 2 years ago

Is there no way of sniffing out the plasma version from code?

No unfortunately. It's actually worse, because this is a metadata issue, which happens far before any of the code can get executed. 🥲

esjeon commented 2 years ago

I just reverted the latest change to the metadata: 5bb950eebf70e84c6f86076b2c826b0622ed85f0.

It seems like KWin also made a new release, which added back the support for the legacy behavior.