search

esjeon / krohnkite

A dynamic tiling extension for KWin
MIT License
1.67k stars 68 forks source link

Tiling Layout stopped working on some windows after upgrade to Plasma 5.27 #213

Open clupasq opened 1 year ago

clupasq commented 1 year ago

Symptom

After upgrading to KDE 5.27, many windows are not affected by Krohnkite.

How to Reproduce

  1. Update to KDE Plasma 5.27.0
  2. Open a the system settings window, or a Konsole terminal
  3. Note that these are not resized as the current tiling settings require: for me, Konsole opens full screen and the system settings are in Floating mode.
  4. Other windows (ex: Brave browser) obey the tiling layout just fine. If only Brave windows are open on a desktop, all seems well. Opening a Konsole terminal makes the terminal full screen, and the Brave window half screen (obeying tiling).

Expected behavior

I expect all windows to be affected by my current tiling settings (except the ones specifically blacklisted in the Krohnkite settings, like Spectacle for example).

Environment

Notes

absorb-it commented 1 year ago

Same here, not working on 5.27.2, was working on 5.26.5 before.

absorb-it commented 1 year ago

implemented some temporary fix (ugly, works-for-me) and added as pull-request. Building from https://github.com/absorb-it/krohnkite with this change works now on kwin 5.27

Be aware that I have no idea what the modified variables are used for and what might be affected additionally by this change - it just prevents running into this bug. Additional fixes might be required.

Best regards, Rene

clupasq commented 1 year ago

Thank you, @absorb-it !

I confirm that your fix works for me as well. :+1:

ghost commented 1 year ago

tried to compile it but got this error instead:

tsc
make: tsc: No such file or directory
make: *** [Makefile:71: krohnkite.js] Error 127

what causes this problem?

clupasq commented 1 year ago

tried to compile it but got this error instead:

tsc
make: tsc: No such file or directory
make: *** [Makefile:71: krohnkite.js] Error 127

what causes this problem?

It appears that you don't have the TypeScript compiler installed.

Try to install it with:

npm i --location=global typescript
ghost commented 1 year ago

It appears that you don't have the TypeScript compiler installed.

turns out it was not installed yet, thank you so much! :D

orange-toothbrush commented 1 year ago

Can confirm this fix works. Thanks @absorb-it

Matt-Kou commented 10 months ago

This is not working for me on 5.27.4. Just to make sure that I am using it correctly:

  1. click on the window to tile
  2. meta + T
  3. select the zone for the window

Nothing happens after I select the directed zone

wokawoka commented 2 months ago

I am not experiencing any issues (1,5 years later) on KDE 5.27.11. Everything seems to work well on 0.8.1 (at least for now).