esjeon / krohnkite

A dynamic tiling extension for KWin
MIT License
1.71k stars 71 forks source link

Comma (,) at the end of Ignore rules breaks/prevents krohnkite from working #223

Open Likivik opened 3 months ago

Likivik commented 3 months ago

Symptom Comma , at the end of Ignore rules breaks/prevents krohnkite from working - no tiling, no response to shortcuts. (another symptom is windows' z-index seems to be messed up, meaning some newly opened windows show up below previously active window, which I guess indicates some window management going on 🤔)

How to Reproduce

  1. Open KDE Plasma 6 Settings -> KWin Scripts -> Krohnkite settings -> Rules
  2. Add a comma , to the end of any ignore rule
  3. Apply settings, observe results. (Rebooting, reactivating the script, logging out doesn't fix it)

Expected behavior Comma is either removed automatically on 'Apply'/'OK' or a warning preventing from Applying with an explanation.

Environment

Notes Took me a while to diagnose the issue. Not sure how Krohnkite is structured, seems like an issue at the 'reading configuration' stage, if there is such a thing. Perhaps it's a KWin scripting issue, in which case close it as upstream.

P.S.: Huge thanks for the existence of this project!