search

eskerda / pybikes

bike sharing + python = pybikes
https://citybik.es
GNU Lesser General Public License v3.0
559 stars 169 forks source link

Real address #21

Open psyrax opened 10 years ago

psyrax commented 10 years ago

Addresses for some networks are wrong, for instance in ecobici 251 GOETHE-DARWIN, should be Goethe 17, Anzures, Miguel Hidalgo, 11590 Mexico City, Federal District, Mexico. I know that came from the original source but using reverse geocoding api from google it could be possible to catch the real addresses as in this example: http://ecobicidx-20724.onmodulus.net/stations/all

eskerda commented 10 years ago

Yes. In fact, most systems that do provide the address are not doing it correctly. I've been thinking for a while about running a reverse geocoding lookup on all stations for all systems and not just the ones that include it on the original feed, but that poses the following question:

Is there a need for the 'address' field at all? I can't think of an scenario where this field would come in handy, but I have no problem adding it if that does make the API more useful.

psyrax commented 10 years ago

I think information must be more accurate than original services. Real address could be used to find a location without use of a map as in here: http://ecobicidx-20724.onmodulus.net/#/test

eskerda commented 10 years ago

information must be more accurate than original services

Agreed. I will add an Station.lookupAddress() method in pybikes, and from there it should be possible to run that on a batch server-side (on the sync step) so it is reflected into the API too.