search

eskimoblood / jim-knopf

:o: small JavaScript library to create knobs using SVG
http://eskimoblood.github.com/jim-knopf/
199 stars 44 forks source link

Add data-labels attribute to turn knob into a multiple choice switch #3

Closed wakandan closed 10 years ago

wakandan commented 10 years ago

same as #2, did a little bit of clean up at redundant places & to minimize changes caused by auto-format like the last time.

eskimoblood commented 10 years ago

So, just 2 minor issues. Btw. you can just push the changes to your fork and don't need to create a new pull request. As in the end github will merge your forked branch in to the master branch.

wakandan commented 10 years ago

Oh I can do that? This pull request will be updated with my new push?

eskimoblood commented 10 years ago

Thanks for fixing the minor stuff. Will merge it

wakandan commented 10 years ago

Thanks a lot!

wakandan commented 10 years ago

By the way I was trying out this code with preset 5 with label text added but it just won't work. The pointer and the dial never align...

eskimoblood commented 10 years ago

Could you please open an issue for this.

wakandan commented 10 years ago

ok I will open an issue and what happened.