search

esl-epfl / szcore

ORD hackaton
MIT License
0 stars 1 forks source link

ci(evaluation): network isolation #39

Closed cmdoret closed 3 days ago

cmdoret commented 3 days ago

Fixes network isolatioon in evaluation CI.

Before, a custom bridge network was created; this isolates the image from other docker images on the host, but bridge networks are connected to the web.

Instead, this PR uses the default none network, which uses the 'null' driver, completely disconnecting it from the network.

greut commented 3 days ago

@cmdoret Sorry, but I broke it...

The workflow is not valid. .github/workflows/algorithm-evaluation.yml (Line: 28, Col: 13): Unexpected symbol: '"false"'. Located at position 45 within expression: steps.find-algorithm.outputs.any_changed != "false"

Maybe without the quotes?

greut commented 3 days ago 
-${{ steps.find-algorithm.outputs.any_changed != "false" }}
+${{ steps.find-algorithm.outputs.any_changed }}
cmdoret commented 3 days ago

thanks for letting me know @greut ! I think we don't need the variable syntax here and modified it to follow the example in https://github.com/tj-actions/changed-files?tab=readme-ov-file#using-local-git-directory-

greut commented 3 days ago

@cmdoret you've changed the meaning. It needs to run if any_changed, right? In the current case, you've got: for algo in ; do. See: https://github.com/esl-epfl/szcore/actions/runs/11776237900/job/32798244591#step:4:9

cmdoret commented 3 days ago

Indded, good catch @greut thanks! addressed directly in https://github.com/esl-epfl/szcore/commit/3dd3c198499181ebc9e446ba55206f9d1934fa2e