esl-epfl / x-heep

eXtendable Heterogeneous Energy-Efficient Platform based on RISC-V
Other
129 stars 69 forks source link

Implementation of a Multichannel DMA #517

Open TommiTerza opened 1 month ago

TommiTerza commented 1 month ago

This PR is based on the 2D DMA implemented in PR number #497

JuanSapriza commented 1 month ago

@TommiTerza I finished a first pass of comment. Mostly minor changes. Hell of a work! Well done!

I haven't gone through the update in the documentation, but i guess the figure will need some updates right? Maybe a whole remake? Just sent you an invitation to edit the diagram (the fourth page)

TommiTerza commented 1 month ago

@JuanSapriza Thanks you! Glad you liked my work :) As you said, the documentation will undergo a full remake, which will encompas both this PR, the 2D DMA one and the smart DMA one, which will follow this PR. The figure will be modifed, just like the examples. For this reason, I'd like to pospone the documentation update and to include it in the smart DMA PR.

JuanSapriza commented 1 month ago

Agree!