search

esl-epfl / x-heep

eXtendable Heterogeneous Energy-Efficient Platform based on RISC-V
Other
141 stars 75 forks source link

fix compilation errors of dma_sdk with ohw compiler #532

Closed LuigiGiuffrida98 closed 3 months ago

LuigiGiuffrida98 commented 3 months ago

@JuanSapriza @JoseCalero can you please review this PR?

JoseCalero commented 3 months ago

it is OK, but the PR is still on draft mode, why? are we waiting to more changings?

JoseCalero commented 3 months ago

ok, i have been debugging a bit, so far this is the output:

TESTING SINGLE MODE

TEST: Data size: 16 Signed: 0 Source type size: 8-bit Destination type size: 8-bit Padding not valid Dimensionality not valid tran: 10021 Error! load: 512 Error! laun: 512 Error!

As you can see, we have problems when validating the transaction (see dma_validate_transaction)... Specifically for the Padding and the dimensionality... @JuanSapriza could you help us debugging this?

Edit: Actually, i just verified that is new functionality because of the 2D added by @TommiTerza in #497 --> was that app even working on that PR??

Edit2: it should have been working because in #498 was tested and verified.... then i do not know why are we getting these specific errors now on the validation of the transaction

LuigiGiuffrida98 commented 3 months ago

Fixed all the issues, some fields of the DMA structures where not properly initialized, now everything is set to 0. example_dma is now working both with riscv32-unknown and riscv32-corev toolchains.

JuanSapriza commented 3 months ago

Hello @LuigiGiuffrida98 @JoseCalero Just getting up to speed with all this. Is anything needed from my side or is this fixed?