Closed arcusfelis closed 5 years ago
4970.2 / Erlang 19.3 / internal_mnesia / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
4970.3 / Erlang 19.3 / mysql_redis / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
4970.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
4970.5 / Erlang 19.3 / ldap_mnesia / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
4970.4 / Erlang 19.3 / odbc_mssql_mnesia / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
4970.9 / Erlang 18.3 / riak_mnesia / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 1229 / Failed: 0 / User-skipped: 93 / Auto-skipped: 0
4970.8 / Erlang 20.0 / pgsql_mnesia / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
4970.9 / Erlang 18.3 / riak_mnesia / 3a75893828615db149aa42eee5a6f6765674b610 Reports root / big / small OK: 1229 / Failed: 0 / User-skipped: 93 / Auto-skipped: 0
Merging #1948 into master will increase coverage by
0.07%
. The diff coverage is73.62%
.
@@ Coverage Diff @@
## master #1948 +/- ##
==========================================
+ Coverage 74.75% 74.83% +0.07%
==========================================
Files 309 314 +5
Lines 28047 28429 +382
==========================================
+ Hits 20966 21274 +308
- Misses 7081 7155 +74
Impacted Files | Coverage Δ | |
---|---|---|
src/config/mongoose_config_helper.erl | 0% <0%> (ø) |
|
src/gen_mod_deps.erl | 100% <100%> (ø) |
:arrow_up: |
src/ejabberd_listener.erl | 72.05% <100%> (ø) |
:arrow_up: |
src/config/mongoose_config_utils.erl | 25.92% <25.92%> (ø) |
|
src/ejabberd_admin.erl | 58.76% <33.33%> (-0.28%) |
:arrow_down: |
src/gen_mod.erl | 75.53% <50%> (-1.91%) |
:arrow_down: |
src/ejabberd_config.erl | 70.78% <66.66%> (+6.85%) |
:arrow_up: |
src/mongoose_cluster.erl | 72.36% <75%> (-0.24%) |
:arrow_down: |
src/config/mongoose_config_flat.erl | 75.97% <75.97%> (ø) |
|
src/config/mongoose_config_parser.erl | 76.29% <76.29%> (ø) |
|
... and 18 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 984dd6d...4c26be5. Read the comment docs.
4971.3 / Erlang 19.3 / mysql_redis / e057394cb65c6b8886b3ea3b058975bb639b32fb Reports root / big / small OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
4971.2 / Erlang 19.3 / internal_mnesia / e057394cb65c6b8886b3ea3b058975bb639b32fb Reports root / big / small OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
4971.4 / Erlang 19.3 / odbc_mssql_mnesia / e057394cb65c6b8886b3ea3b058975bb639b32fb Reports root / big / small OK: 2810 / Failed: 1 / User-skipped: 209 / Auto-skipped: 0
4971.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / e057394cb65c6b8886b3ea3b058975bb639b32fb Reports root / big / small OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
4971.5 / Erlang 19.3 / ldap_mnesia / e057394cb65c6b8886b3ea3b058975bb639b32fb Reports root / big / small OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
4971.8 / Erlang 20.0 / pgsql_mnesia / e057394cb65c6b8886b3ea3b058975bb639b32fb Reports root / big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
Extended node_specific_options list for Global Distribution modules.
{node_specific_options, [
[h,'_',module_opt,mod_global_distrib,endpoints],
[h,'_',module_opt,mod_global_distrib,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib,connections,endpoints],
[h,'_',module_subopt,mod_global_distrib,connections,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib,redis,server],
[h,'_',module_subopt,mod_global_distrib_bounce,connections,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_bounce,connections,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_bounce,connections,endpoints],
[h,'_',module_subopt,mod_global_distrib_bounce,connections,endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_disco,connections,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_disco,connections,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_hosts_refresher,connections,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_hosts_refresher,connections,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_hosts_refresher,connections,endpoints],
[h,'_',module_subopt,mod_global_distrib_hosts_refresher,connections,endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_hosts_refresher,redis,server],
[h,'_',module_subopt,mod_global_distrib_mapping,connections,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_mapping,connections,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_mapping,connections,endpoints],
[h,'_',module_subopt,mod_global_distrib_mapping,connections,endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_mapping,redis,server],
[h,'_',module_subopt,mod_global_distrib_receiver,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_receiver,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_receiver,connections,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_receiver,connections,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_receiver,connections,endpoints],
[h,'_',module_subopt,mod_global_distrib_receiver,connections,endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_receiver,endpoints],
[h,'_',module_subopt,mod_global_distrib_receiver,endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_receiver,redis,server],
[h,'_',module_subopt,mod_global_distrib_sender,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_sender,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_sender,connections,advertised_endpoints],
[h,'_',module_subopt,mod_global_distrib_sender,connections,advertised_endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_sender,connections,endpoints],
[h,'_',module_subopt,mod_global_distrib_sender,connections,endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_sender,endpoints],
[h,'_',module_subopt,mod_global_distrib_sender,endpoints,'_'],
[h,'_',module_subopt,mod_global_distrib_sender,redis,server]
]}.
4974.2 / Erlang 19.3 / internal_mnesia / 0a06ce173738d89bcf69b9b5bd253b7f71a1681a Reports root / big / small OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
4974.3 / Erlang 19.3 / mysql_redis / 0a06ce173738d89bcf69b9b5bd253b7f71a1681a Reports root / big / small OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
4974.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 0a06ce173738d89bcf69b9b5bd253b7f71a1681a Reports root / big / small OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
4974.5 / Erlang 19.3 / ldap_mnesia / 0a06ce173738d89bcf69b9b5bd253b7f71a1681a Reports root / big / small OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
4974.4 / Erlang 19.3 / odbc_mssql_mnesia / 0a06ce173738d89bcf69b9b5bd253b7f71a1681a Reports root / big / small OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
4974.8 / Erlang 20.0 / pgsql_mnesia / 0a06ce173738d89bcf69b9b5bd253b7f71a1681a Reports root / big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
4982.2 / Erlang 19.3 / internal_mnesia / aab6ac9352eed24c3a7aed83d7818154c9f5f90e Reports root / big / small OK: 1071 / Failed: 3 / User-skipped: 41 / Auto-skipped: 0
4982.3 / Erlang 19.3 / mysql_redis / aab6ac9352eed24c3a7aed83d7818154c9f5f90e Reports root / big / small OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
4982.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / aab6ac9352eed24c3a7aed83d7818154c9f5f90e Reports root / big / small OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
4982.5 / Erlang 19.3 / ldap_mnesia / aab6ac9352eed24c3a7aed83d7818154c9f5f90e Reports root / big / small OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
4982.4 / Erlang 19.3 / odbc_mssql_mnesia / aab6ac9352eed24c3a7aed83d7818154c9f5f90e Reports root / big / small OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
4982.8 / Erlang 20.0 / pgsql_mnesia / aab6ac9352eed24c3a7aed83d7818154c9f5f90e Reports root / big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
4982.2 / Erlang 19.3 / internal_mnesia / aab6ac9352eed24c3a7aed83d7818154c9f5f90e Reports root / big / small OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
4985.5 / Erlang 19.3 / ldap_mnesia / bab378b4da547b365408a8907e71fbf3aae934e9 Reports root / big / small OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
4985.3 / Erlang 19.3 / mysql_redis / bab378b4da547b365408a8907e71fbf3aae934e9 Reports root / big / small OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
4985.2 / Erlang 19.3 / internal_mnesia / bab378b4da547b365408a8907e71fbf3aae934e9 Reports root / big / small OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
4985.4 / Erlang 19.3 / odbc_mssql_mnesia / bab378b4da547b365408a8907e71fbf3aae934e9 Reports root / big / small OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
4985.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / bab378b4da547b365408a8907e71fbf3aae934e9 Reports root / big / small OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
4985.8 / Erlang 20.0 / pgsql_mnesia / bab378b4da547b365408a8907e71fbf3aae934e9 Reports root / big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
@michalwski @goddammit
I'd like to wait with language review until the technical one is done (it's ~60% ready), as docs may change further eventually. :)
:+1: for moving config-related modules to new subdir
4999.3 / Erlang 19.3 / mysql_redis / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root/ big
4999.2 / Erlang 19.3 / internal_mnesia / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root/ big
4999.5 / Erlang 19.3 / ldap_mnesia / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root/ big
4999.4 / Erlang 19.3 / odbc_mssql_mnesia / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root/ big
4999.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root/ big
4999.8 / Erlang 20.0 / pgsql_mnesia / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root/ big / small
4999.9 / Erlang 21.0 / riak_mnesia / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root/ big / small
4999.1 / Erlang 19.3 / small_tests / a4c1a1f0cbff8260aa506cfcea16826eee70cec8 Reports root / small
5000.2 / Erlang 19.3 / internal_mnesia / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root/ big
5000.3 / Erlang 19.3 / mysql_redis / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root/ big
5000.4 / Erlang 19.3 / odbc_mssql_mnesia / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root/ big
5000.5 / Erlang 19.3 / ldap_mnesia / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root/ big
5000.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root/ big
5000.8 / Erlang 20.0 / pgsql_mnesia / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root/ big / small
5000.9 / Erlang 21.0 / riak_mnesia / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root/ big / small
5000.1 / Erlang 19.3 / small_tests / b2d18939268545cae1e279665beb7151dd91b6d7 Reports root / small
5002.2 / Erlang 19.3 / internal_mnesia / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root/ big
5002.3 / Erlang 19.3 / mysql_redis / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root/ big
5002.4 / Erlang 19.3 / odbc_mssql_mnesia / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root/ big
5002.5 / Erlang 19.3 / ldap_mnesia / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root/ big
5002.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root/ big
5002.1 / Erlang 19.3 / small_tests / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root / small
5002.8 / Erlang 20.0 / pgsql_mnesia / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root/ big / small
5002.9 / Erlang 21.0 / riak_mnesia / d3ce3f42a79f8e640243cc77ebf8a3680a536dc2 Reports root/ big / small
@michalwski
I wonder if we can rename ejabberd_config to mongoose_config since it was so heavily rewrote. I know it would mean renaming the new mongoose_config to some other name.
good idea, not in this PR, please. Because it requires replacing ejabberd_config with mongoose_config in all tests, which would be very hard to review (a lot of small changes easier to review as a separate PR). Actually, moving ejabberd_config into config/ directory ALREADY broke github diff for this file.
Do you think it'd be worth extracting functions related to config reload from mongoose_config to new module?
mongoose_config was separated into mongoose_config_parser and mongoose_config_reload
Maybe all the modules related to configuration could be moved to their own subdir, probably named config.
done
@arcusfelis I'm fine with renaming ejabberd_config
to mongoose_config
in a separate PR. Thanks for applying my other comments.
@michalwski Rebased my PR, so ejabberd_config
remains in src/
, so we can have a working diff.
It's very important for this PR, because it helps to understand modifications (easier to review).
@arcusfelis
Rebased my PR, so ejabberd_config remains in src/, so we can have a working diff. It's very important for this PR, because it helps to understand modifications (easier to review).
That's ok, I understand that, thanks!
5013.2 / Erlang 19.3 / internal_mnesia / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root/ big
5013.3 / Erlang 19.3 / mysql_redis / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root/ big
5013.5 / Erlang 19.3 / ldap_mnesia / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root/ big
5013.4 / Erlang 19.3 / odbc_mssql_mnesia / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root/ big
5013.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root/ big
5013.8 / Erlang 20.0 / pgsql_mnesia / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root/ big / small
5013.1 / Erlang 19.3 / small_tests / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root / small
5013.9 / Erlang 21.0 / riak_mnesia / 09e4592e10b2501c8c63864145abe736728f4ff9 Reports root/ big / small
5019.2 / Erlang 19.3 / internal_mnesia / de30b0c6b97510802c1053db3b35fd91bf17ebf3 Reports root/ big OK: 1049 / Failed: 147 / User-skipped: 46 / Auto-skipped: 7
1 errors were truncated
5019.3 / Erlang 19.3 / mysql_redis / de30b0c6b97510802c1053db3b35fd91bf17ebf3 Reports root/ big OK: 1151 / Failed: 205 / User-skipped: 81 / Auto-skipped: 1831
1 errors were truncated
5019.1 / Erlang 19.3 / small_tests / de30b0c6b97510802c1053db3b35fd91bf17ebf3 Reports root / small
I closed and re-opened to trigger travis, it didn't start previously.
5029.1 / Erlang 19.3 / small_tests / c19e495ebff18dd9254a1c4b9e423838cf82cc4a Reports root / small
5029.5 / Erlang 19.3 / ldap_mnesia / c19e495ebff18dd9254a1c4b9e423838cf82cc4a Reports root/ big OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5029.3 / Erlang 19.3 / mysql_redis / c19e495ebff18dd9254a1c4b9e423838cf82cc4a Reports root/ big OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5029.2 / Erlang 19.3 / internal_mnesia / c19e495ebff18dd9254a1c4b9e423838cf82cc4a Reports root/ big OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
@michalwski actually it was stopped by me, so I can fix an issue with slave nodes on travis and not waste travis time.
5030.1 / Erlang 19.3 / small_tests / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root / small
5030.2 / Erlang 19.3 / internal_mnesia / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root/ big OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5030.3 / Erlang 19.3 / mysql_redis / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root/ big OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5030.4 / Erlang 19.3 / odbc_mssql_mnesia / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root/ big OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
5030.5 / Erlang 19.3 / ldap_mnesia / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root/ big OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5030.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5030.8 / Erlang 20.0 / pgsql_mnesia / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root/ big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
5030.9 / Erlang 21.0 / riak_mnesia / 76c84691bbb79f13e5a91a549f0701cb58136bd3 Reports root/ big / small OK: 1279 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0
This PR addresses "mod_global_distrib with advertised endpoints does not work correctly with reload_cluster, because configs are different for each node".
Proposed changes include: