Closed bartekgorny closed 5 years ago
5001.1 / Erlang 19.3 / small_tests / 52c4adcd1f0ce0608347605aa524b5ed3514a0f3 Reports root / small
5001.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 52c4adcd1f0ce0608347605aa524b5ed3514a0f3 Reports root/ big OK: 9 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5001.3 / Erlang 19.3 / mysql_redis / 52c4adcd1f0ce0608347605aa524b5ed3514a0f3 Reports root/ big OK: 1146 / Failed: 69 / User-skipped: 74 / Auto-skipped: 18
1 errors were truncated
5001.2 / Erlang 19.3 / internal_mnesia / 52c4adcd1f0ce0608347605aa524b5ed3514a0f3 Reports root/ big OK: 990 / Failed: 69 / User-skipped: 29 / Auto-skipped: 74
1 errors were truncated
5001.4 / Erlang 19.3 / odbc_mssql_mnesia / 52c4adcd1f0ce0608347605aa524b5ed3514a0f3 Reports root/ big OK: 1141 / Failed: 69 / User-skipped: 61 / Auto-skipped: 18
1 errors were truncated
:+1: for all of Michał's comments.
Merging #1955 into master will decrease coverage by
0.01%
. The diff coverage is94.28%
.
@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
- Coverage 74.87% 74.86% -0.02%
==========================================
Files 314 312 -2
Lines 28430 28421 -9
==========================================
- Hits 21287 21277 -10
- Misses 7143 7144 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/ejabberd_app.erl | 86.45% <100%> (+0.14%) |
:arrow_up: |
src/ejabberd_sm.erl | 84.17% <100%> (+1.12%) |
:arrow_up: |
src/mongoose_wpool.erl | 100% <100%> (ø) |
|
src/mongoose_riak.erl | 95.83% <100%> (+0.08%) |
:arrow_up: |
src/ejabberd_sm_redis.erl | 97.91% <100%> (+1.91%) |
:arrow_up: |
src/auth/ejabberd_auth_http.erl | 70.58% <100%> (-1.98%) |
:arrow_down: |
src/mongoose_http_client.erl | 88% <86.48%> (-7.84%) |
:arrow_down: |
src/mongoose_redis.erl | 95.23% <95.23%> (ø) |
|
src/pubsub/nodetree_tree.erl | 17.74% <0%> (-29.04%) |
:arrow_down: |
src/mam/mod_mam_muc_odbc_async_pool_writer.erl | 62.76% <0%> (-4.26%) |
:arrow_down: |
... and 15 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8fd6804...c17fdd7. Read the comment docs.
5011.1 / Erlang 19.3 / small_tests / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root / small
5011.3 / Erlang 19.3 / mysql_redis / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root/ big OK: 1168 / Failed: 9 / User-skipped: 74 / Auto-skipped: 0
5011.2 / Erlang 19.3 / internal_mnesia / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root/ big OK: 1012 / Failed: 9 / User-skipped: 29 / Auto-skipped: 56
5011.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root/ big OK: 9 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5011.4 / Erlang 19.3 / odbc_mssql_mnesia / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root/ big OK: 1163 / Failed: 9 / User-skipped: 61 / Auto-skipped: 0
5011.5 / Erlang 19.3 / ldap_mnesia / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root/ big OK: 976 / Failed: 9 / User-skipped: 65 / Auto-skipped: 56
5011.8 / Erlang 20.0 / pgsql_mnesia / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root/ big / small OK: 1214 / Failed: 9 / User-skipped: 28 / Auto-skipped: 0
5011.9 / Erlang 21.0 / riak_mnesia / d0114926ba7a975da98a6fd2b97c84abdcab2ad1 Reports root/ big / small OK: 1002 / Failed: 9 / User-skipped: 39 / Auto-skipped: 56
5022.1 / Erlang 19.3 / small_tests / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root / small
5022.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root/ big OK: 9 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5028.1 / Erlang 19.3 / small_tests / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root / small
5028.2 / Erlang 19.3 / internal_mnesia / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root/ big OK: 1012 / Failed: 9 / User-skipped: 29 / Auto-skipped: 56
5028.3 / Erlang 19.3 / mysql_redis / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root/ big OK: 1168 / Failed: 9 / User-skipped: 74 / Auto-skipped: 0
5028.5 / Erlang 19.3 / ldap_mnesia / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root/ big OK: 976 / Failed: 9 / User-skipped: 65 / Auto-skipped: 56
5028.4 / Erlang 19.3 / odbc_mssql_mnesia / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root/ big OK: 1163 / Failed: 9 / User-skipped: 61 / Auto-skipped: 0
5028.9 / Erlang 21.0 / riak_mnesia / a850dd2c5801011052e8c8ceee5946fb9d5c514a Reports root/ big / small OK: 739 / Failed: 1041 / User-skipped: 34 / Auto-skipped: 175
1 errors were truncated
I have a general question: do we care about backward compatibility? Some of the tweaks I did are there because various modules have different configuration definitions, so now each module has a bit of code which translates the module's config into worker_pool. If we decide to unify configs as well, then indeed the abstraction becomes much easier.
Could you give a concrete example what would not be backward compatible and who/what would be affected? I think we can sacrifice backward compatibility in favour or simpler and cleaner code.
Configs - e.g. sm defines 'pool_size', while http auth has 'connection_pool_size', so some existing installations may require config update to continue. No idea who exactly would be affected :)
I think at some point we'll need to break this backward compatibility. Most probably there will be more changes around pools so it could be done in (near) future. @fenek what do you think?
@michalwski I think #1959 :)
IMO current state of this PR is a good compromise and I'm not sure if we should try to predict next PRs needs inside this one. It covers the scope of a task.
We'll definitely have to break backward compatibility at some point. We may afford a transition period where ejabberd_config
will be able to translate old schema to new one but it shouldn't stay like this for longer than 1-2 versions.
Additionally, I'm considering a dedicated "Migration" section in our docs with precise instructions how to switch from one version to the next one. Such page(s) should be perfectly sufficient, especially given that we want to unify and simplify pools configuration, not make it more complicated.
5032.1 / Erlang 19.3 / small_tests / f98745f64da7987c57e5b364215f4fcd53099150 Reports root / small
5032.3 / Erlang 19.3 / mysql_redis / f98745f64da7987c57e5b364215f4fcd53099150 Reports root/ big OK: 1171 / Failed: 0 / User-skipped: 74 / Auto-skipped: 0
5032.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / f98745f64da7987c57e5b364215f4fcd53099150 Reports root/ big OK: 9 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5032.4 / Erlang 19.3 / odbc_mssql_mnesia / f98745f64da7987c57e5b364215f4fcd53099150 Reports root/ big OK: 1166 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0
5032.5 / Erlang 19.3 / ldap_mnesia / f98745f64da7987c57e5b364215f4fcd53099150 Reports root/ big OK: 979 / Failed: 0 / User-skipped: 65 / Auto-skipped: 56
5032.2 / Erlang 19.3 / internal_mnesia / f98745f64da7987c57e5b364215f4fcd53099150 Reports root/ big OK: 1015 / Failed: 0 / User-skipped: 29 / Auto-skipped: 56
5032.8 / Erlang 20.0 / pgsql_mnesia / f98745f64da7987c57e5b364215f4fcd53099150 Reports root/ big / small OK: 1217 / Failed: 0 / User-skipped: 28 / Auto-skipped: 0
5035.1 / Erlang 19.3 / small_tests / 1a8c44670ad8931b656cc977f030222030887ec7 Reports root / small
5035.3 / Erlang 19.3 / mysql_redis / 1a8c44670ad8931b656cc977f030222030887ec7 Reports root/ big
1 errors were truncated
5035.2 / Erlang 19.3 / internal_mnesia / 1a8c44670ad8931b656cc977f030222030887ec7 Reports root/ big
1 errors were truncated
5035.4 / Erlang 19.3 / odbc_mssql_mnesia / 1a8c44670ad8931b656cc977f030222030887ec7 Reports root/ big
1 errors were truncated
5035.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 1a8c44670ad8931b656cc977f030222030887ec7 Reports root/ big OK: 9 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5035.5 / Erlang 19.3 / ldap_mnesia / 1a8c44670ad8931b656cc977f030222030887ec7 Reports root/ big
1 errors were truncated
5036.1 / Erlang 19.3 / small_tests / c8986f87763105d2449d2bf428d1e1868971bf5c Reports root / small
5036.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / c8986f87763105d2449d2bf428d1e1868971bf5c Reports root/ big OK: 9 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5036.3 / Erlang 19.3 / mysql_redis / c8986f87763105d2449d2bf428d1e1868971bf5c Reports root/ big OK: 1171 / Failed: 0 / User-skipped: 74 / Auto-skipped: 0
5036.5 / Erlang 19.3 / ldap_mnesia / c8986f87763105d2449d2bf428d1e1868971bf5c Reports root/ big OK: 979 / Failed: 0 / User-skipped: 65 / Auto-skipped: 56
5036.2 / Erlang 19.3 / internal_mnesia / c8986f87763105d2449d2bf428d1e1868971bf5c Reports root/ big OK: 1015 / Failed: 0 / User-skipped: 29 / Auto-skipped: 56
5036.4 / Erlang 19.3 / odbc_mssql_mnesia / c8986f87763105d2449d2bf428d1e1868971bf5c Reports root/ big OK: 1166 / Failed: 0 / User-skipped: 61 / Auto-skipped: 0
5037.1 / Erlang 19.3 / small_tests / 7a6acdfeb3a7f4697afb306a7ea32b8fb4e6eee7 Reports root / small
5037.3 / Erlang 19.3 / mysql_redis / 7a6acdfeb3a7f4697afb306a7ea32b8fb4e6eee7 Reports root/ big
1 errors were truncated
5037.5 / Erlang 19.3 / ldap_mnesia / 7a6acdfeb3a7f4697afb306a7ea32b8fb4e6eee7 Reports root/ big
1 errors were truncated
5037.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 7a6acdfeb3a7f4697afb306a7ea32b8fb4e6eee7 Reports root/ big OK: 9 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5037.2 / Erlang 19.3 / internal_mnesia / 7a6acdfeb3a7f4697afb306a7ea32b8fb4e6eee7 Reports root/ big
1 errors were truncated
5037.4 / Erlang 19.3 / odbc_mssql_mnesia / 7a6acdfeb3a7f4697afb306a7ea32b8fb4e6eee7 Reports root/ big
1 errors were truncated
5037.8 / Erlang 20.0 / pgsql_mnesia / 7a6acdfeb3a7f4697afb306a7ea32b8fb4e6eee7 Reports root/ big / small
1 errors were truncated
5040.1 / Erlang 19.3 / small_tests / 8eedf24a6629e2cabcfdf9d04e5df25d03c12a83 Reports root / small
5040.5 / Erlang 19.3 / ldap_mnesia / 8eedf24a6629e2cabcfdf9d04e5df25d03c12a83 Reports root/ big OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5040.3 / Erlang 19.3 / mysql_redis / 8eedf24a6629e2cabcfdf9d04e5df25d03c12a83 Reports root/ big OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5040.2 / Erlang 19.3 / internal_mnesia / 8eedf24a6629e2cabcfdf9d04e5df25d03c12a83 Reports root/ big OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5040.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 8eedf24a6629e2cabcfdf9d04e5df25d03c12a83 Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5040.4 / Erlang 19.3 / odbc_mssql_mnesia / 8eedf24a6629e2cabcfdf9d04e5df25d03c12a83 Reports root/ big OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
5040.8 / Erlang 20.0 / pgsql_mnesia / 8eedf24a6629e2cabcfdf9d04e5df25d03c12a83 Reports root/ big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
5041.1 / Erlang 19.3 / small_tests / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root / small
5041.5 / Erlang 19.3 / ldap_mnesia / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root/ big OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5041.3 / Erlang 19.3 / mysql_redis / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root/ big OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5041.2 / Erlang 19.3 / internal_mnesia / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root/ big OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5041.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5041.4 / Erlang 19.3 / odbc_mssql_mnesia / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root/ big OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
5041.8 / Erlang 20.0 / pgsql_mnesia / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root/ big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
5041.9 / Erlang 21.0 / riak_mnesia / 940f6497c7b670d32fa95cc1e72b633f6dc012a9 Reports root/ big / small OK: 770 / Failed: 1079 / User-skipped: 50 / Auto-skipped: 119
1 errors were truncated
5042.1 / Erlang 19.3 / small_tests / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root / small
5042.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5042.3 / Erlang 19.3 / mysql_redis / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root/ big OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5042.5 / Erlang 19.3 / ldap_mnesia / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root/ big OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5042.2 / Erlang 19.3 / internal_mnesia / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root/ big OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5042.4 / Erlang 19.3 / odbc_mssql_mnesia / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root/ big OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
5042.9 / Erlang 21.0 / riak_mnesia / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root/ big / small OK: 1282 / Failed: 1 / User-skipped: 43 / Auto-skipped: 0
5042.8 / Erlang 20.0 / pgsql_mnesia / f7552e55084d4b3f94b708c5e0a08be4ccde8063 Reports root/ big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
5043.1 / Erlang 19.3 / small_tests / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root / small
5043.5 / Erlang 19.3 / ldap_mnesia / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root/ big OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5043.3 / Erlang 19.3 / mysql_redis / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root/ big OK: 2807 / Failed: 1 / User-skipped: 222 / Auto-skipped: 0
5043.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5043.4 / Erlang 19.3 / odbc_mssql_mnesia / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root/ big OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
5043.2 / Erlang 19.3 / internal_mnesia / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root/ big OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5043.8 / Erlang 20.0 / pgsql_mnesia / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root/ big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
5043.9 / Erlang 21.0 / riak_mnesia / 6926eb7f8839cf33a22b0132da8da8b4d74e2365 Reports root/ big / small OK: 1279 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0
Please prettify commits a bit (commit messages), especially the "fix" one and this PR will be ready to merge.
I thought Michał was going to do it, that's what he told me in the morning.
@bartekgorny @fenek yes, I'm on it.
5047.1 / Erlang 19.3 / small_tests / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root / small
5047.5 / Erlang 19.3 / ldap_mnesia / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big OK: 1024 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5047.3 / Erlang 19.3 / mysql_redis / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big OK: 2799 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5047.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5047.2 / Erlang 19.3 / internal_mnesia / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big OK: 1060 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5047.4 / Erlang 19.3 / odbc_mssql_mnesia / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big OK: 2794 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
5047.9 / Erlang 21.0 / riak_mnesia / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big / small OK: 1282 / Failed: 1 / User-skipped: 43 / Auto-skipped: 0
5047.8 / Erlang 20.0 / pgsql_mnesia / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big / small OK: 2845 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
5047.9 / Erlang 21.0 / riak_mnesia / f4aeb2a6fe8675ef062c81f87ceb23b3f6d4052b Reports root/ big / small OK: 1279 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0
This PR removes cuesport and poolboy, now we are using worker_pool everywhere. Also it removes redo in favour of eredis.