Closed zofpolkowska closed 5 years ago
5052.1 / Erlang 19.3 / small_tests / 2079610da4e053274cadcf670ac6432b9056151f Reports root / small
5052.5 / Erlang 19.3 / ldap_mnesia / 2079610da4e053274cadcf670ac6432b9056151f Reports root/ big OK: 1023 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5052.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 2079610da4e053274cadcf670ac6432b9056151f Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5052.3 / Erlang 19.3 / mysql_redis / 2079610da4e053274cadcf670ac6432b9056151f Reports root/ big OK: 2798 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5052.2 / Erlang 19.3 / internal_mnesia / 2079610da4e053274cadcf670ac6432b9056151f Reports root/ big OK: 1059 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5052.4 / Erlang 19.3 / odbc_mssql_mnesia / 2079610da4e053274cadcf670ac6432b9056151f Reports root/ big OK: 2793 / Failed: 0 / User-skipped: 209 / Auto-skipped: 0
5052.8 / Erlang 20.0 / pgsql_mnesia / 2079610da4e053274cadcf670ac6432b9056151f Reports root/ big / small OK: 2844 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
5052.9 / Erlang 21.0 / riak_mnesia / 2079610da4e053274cadcf670ac6432b9056151f Reports root/ big / small OK: 1278 / Failed: 0 / User-skipped: 43 / Auto-skipped: 0
Merging #1962 into master will increase coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1962 +/- ##
==========================================
+ Coverage 74.9% 74.96% +0.05%
==========================================
Files 313 313
Lines 28459 28459
==========================================
+ Hits 21317 21333 +16
+ Misses 7142 7126 -16
Impacted Files | Coverage Δ | |
---|---|---|
src/mam/mod_mam_odbc_prefs.erl | 92.52% <0%> (-3.74%) |
:arrow_down: |
src/rdbms/mongoose_rdbms.erl | 67.83% <0%> (-2.52%) |
:arrow_down: |
src/mam/mod_mam_muc_odbc_async_pool_writer.erl | 67.02% <0%> (-2.13%) |
:arrow_down: |
src/mam/mod_mam_utils.erl | 82.37% <0%> (-0.68%) |
:arrow_down: |
src/pubsub/mod_pubsub.erl | 65.99% <0%> (+0.06%) |
:arrow_up: |
src/ejabberd_c2s.erl | 84.59% <0%> (+0.14%) |
:arrow_up: |
src/global_distrib/mod_global_distrib_utils.erl | 80.8% <0%> (+1.01%) |
:arrow_up: |
src/muc_light/mod_muc_light_utils.erl | 85.26% <0%> (+1.05%) |
:arrow_up: |
...c/global_distrib/mod_global_distrib_server_mgr.erl | 82.39% <0%> (+2.81%) |
:arrow_up: |
src/pubsub/gen_pubsub_node.erl | 12.5% <0%> (+3.12%) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 73f6c9a...89457a4. Read the comment docs.
@zofpolkowska Congratulations on making your first CI build pass!
5063.1 / Erlang 19.3 / internal_mnesia / 74a984fdf1725dcc2e0d15aa80cc47fe9b8ca575 Reports root/ big OK: 58 / Failed: 1 / User-skipped: 0 / Auto-skipped: 0
5069.1 / Erlang 19.3 / internal_mnesia / 98c4ccf4bde40ef2cbf7b1c9d82dd2186e7ea016 Reports root/ big OK: 107 / Failed: 1 / User-skipped: 0 / Auto-skipped: 0
5076.1 / Erlang 19.3 / internal_mnesia / 2d143096f20536b683907e6776757b4b5f50b0a1 Reports root/ big OK: 132 / Failed: 4 / User-skipped: 0 / Auto-skipped: 0
5079.1 / Erlang 19.3 / internal_mnesia / bebaf9ae97390839181e22e9c1a40564037565af Reports root/ big OK: 121 / Failed: 1 / User-skipped: 0 / Auto-skipped: 0
5081.1 / Erlang 19.3 / internal_mnesia / 978d04efed851b40ac364b06304a650799309061 Reports root/ big OK: 132 / Failed: 4 / User-skipped: 0 / Auto-skipped: 0
5088.1 / Erlang 19.3 / internal_mnesia / 798d606592b1a69fc3f00d78eb0660c38a9952fb Reports root/ big OK: 74 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5095.1 / Erlang 19.3 / internal_mnesia / 98ec9a0d931817ac1ac71b938e7aea17be5bb3a2 Reports root/ big OK: 74 / Failed: 0 / User-skipped: 1 / Auto-skipped: 0
5095.2 / Erlang 19.3 / default / 98ec9a0d931817ac1ac71b938e7aea17be5bb3a2 Reports root/ big / small
5095.2 / Erlang 19.3 / default / 98ec9a0d931817ac1ac71b938e7aea17be5bb3a2 Reports root/ big / small
5098.1 / Erlang 19.3 / internal_mnesia / 51c0e6150b0e30e97f865ca63b51d729f4c4c09b Reports root/ big OK: 74 / Failed: 0 / User-skipped: 1 / Auto-skipped: 0
5098.2 / Erlang 19.3 / pgsql_mnesia / 51c0e6150b0e30e97f865ca63b51d729f4c4c09b Reports root/ big OK: 1575 / Failed: 79 / User-skipped: 148 / Auto-skipped: 48
1 errors were truncated
5104.1 / Erlang 19.3 / internal_mnesia / 30d616650dcd2669213c611ea3a359c9d3b05365 Reports root/ big OK: 156 / Failed: 3 / User-skipped: 7 / Auto-skipped: 0
5105.1 / Erlang 19.3 / internal_mnesia / ae322560617ae1ecadba2eca2cc40ac2f560af57 Reports root/ big OK: 292 / Failed: 0 / User-skipped: 4 / Auto-skipped: 0
5105.2 / Erlang 19.3 / pgsql_mnesia / ae322560617ae1ecadba2eca2cc40ac2f560af57 Reports root/ big OK: 1829 / Failed: 93 / User-skipped: 149 / Auto-skipped: 0
1 errors were truncated
5106.1 / Erlang 19.3 / internal_mnesia / d6cd7d6ca47342585e19bff3bba2390578b3109a Reports root/ big OK: 1 / Failed: 0 / User-skipped: 1 / Auto-skipped: 0
5106.2 / Erlang 19.3 / pgsql_mnesia / d6cd7d6ca47342585e19bff3bba2390578b3109a Reports root/ big OK: 1629 / Failed: 0 / User-skipped: 148 / Auto-skipped: 0
5107.1 / Erlang 19.3 / internal_mnesia / 1cdcf5178328a3cd0e9be278e33f6a49d6b6292c Reports root/ big OK: 135 / Failed: 0 / User-skipped: 3 / Auto-skipped: 0
5107.2 / Erlang 19.3 / pgsql_mnesia / 1cdcf5178328a3cd0e9be278e33f6a49d6b6292c Reports root/ big OK: 1765 / Failed: 0 / User-skipped: 148 / Auto-skipped: 0
5108.1 / Erlang 19.3 / internal_mnesia / 822f114eb58fb56156bf016b2c6993dfe5d52254 Reports root/ big OK: 219 / Failed: 0 / User-skipped: 4 / Auto-skipped: 0
5108.2 / Erlang 19.3 / pgsql_mnesia / 822f114eb58fb56156bf016b2c6993dfe5d52254 Reports root/ big OK: 1849 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0
5109.1 / Erlang 19.3 / internal_mnesia / 332bebace9bae6a434924a10a6db111068eb485a Reports root/ big OK: 249 / Failed: 0 / User-skipped: 4 / Auto-skipped: 0
5109.2 / Erlang 19.3 / pgsql_mnesia / 332bebace9bae6a434924a10a6db111068eb485a Reports root/ big OK: 1879 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0
5111.1 / Erlang 19.3 / internal_mnesia / 5c9b6c248de84fef10091e11af441ff5ffd5eb89 Reports root/ big OK: 276 / Failed: 0 / User-skipped: 4 / Auto-skipped: 0
5111.2 / Erlang 19.3 / pgsql_mnesia / 5c9b6c248de84fef10091e11af441ff5ffd5eb89 Reports root/ big OK: 1906 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0
5113.1 / Erlang 19.3 / internal_mnesia / d8b043e52ca18909ee0a8b4859c2c01dae65fe7c Reports root/ big OK: 292 / Failed: 0 / User-skipped: 4 / Auto-skipped: 0
5113.2 / Erlang 19.3 / pgsql_mnesia / d8b043e52ca18909ee0a8b4859c2c01dae65fe7c Reports root/ big OK: 1922 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0
5114.2 / Erlang 19.3 / pgsql_mnesia / e0c049dd3b1c2a6b515abecfe8987dc1db4a63a2 Reports root/ big OK: 43 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5114.1 / Erlang 19.3 / internal_mnesia / e0c049dd3b1c2a6b515abecfe8987dc1db4a63a2 Reports root/ big OK: 43 / Failed: 0 / User-skipped: 0 / Auto-skipped: 0
5115.1 / Erlang 19.3 / internal_mnesia / fe2628b025bd56dda3f023993071385c3909d9bf Reports root/ big OK: 334 / Failed: 0 / User-skipped: 4 / Auto-skipped: 0
5115.2 / Erlang 19.3 / pgsql_mnesia / fe2628b025bd56dda3f023993071385c3909d9bf Reports root/ big OK: 1964 / Failed: 0 / User-skipped: 149 / Auto-skipped: 0
5121.1 / Erlang 19.3 / small_tests / 254a9404f177ee1456a926881cb8bf1f3cf221ac Reports root / small
5121.6 / Erlang 19.3 / elasticsearch_and_cassandra_mnesia / 254a9404f177ee1456a926881cb8bf1f3cf221ac Reports root/ big OK: 445 / Failed: 0 / User-skipped: 8 / Auto-skipped: 0
5121.2 / Erlang 19.3 / internal_mnesia / 254a9404f177ee1456a926881cb8bf1f3cf221ac Reports root/ big OK: 1063 / Failed: 0 / User-skipped: 41 / Auto-skipped: 0
5121.3 / Erlang 19.3 / mysql_redis / 254a9404f177ee1456a926881cb8bf1f3cf221ac Reports root/ big OK: 2802 / Failed: 0 / User-skipped: 222 / Auto-skipped: 0
5121.4 / Erlang 19.3 / odbc_mssql_mnesia / 254a9404f177ee1456a926881cb8bf1f3cf221ac Reports root/ big OK: 2816 / Failed: 0 / User-skipped: 208 / Auto-skipped: 0
5121.5 / Erlang 19.3 / ldap_mnesia / 254a9404f177ee1456a926881cb8bf1f3cf221ac Reports root/ big OK: 1027 / Failed: 0 / User-skipped: 77 / Auto-skipped: 0
5121.8 / Erlang 20.0 / pgsql_mnesia / 254a9404f177ee1456a926881cb8bf1f3cf221ac Reports root/ big / small OK: 2848 / Failed: 0 / User-skipped: 176 / Auto-skipped: 0
Oh, and please edit the description of the PR so that it says a bit more about the changes than just trigger travis
:)
I also think that the commits history could be improved a bit with git rebase
. Commits which only reduce number of jobs or use only some SUITEs could be removed (if possible) or squashed.
5124.9 / Erlang 21.0 / riak_mnesia / e55ca397fe1ff6ab937d81eddce70ed4a31937b6 Reports root/ big / small OK: 1281 / Failed: 3 / User-skipped: 43 / Auto-skipped: 0
Thanks for review! Made requested changes and improved a bit history
5133.2 / Erlang 19.3 / internal_mnesia / d15d59a8a19db20a08761e6f4b2c1b81df61965a Reports root/ big OK: 1069 / Failed: 3 / User-skipped: 41 / Auto-skipped: 0
5133.3 / Erlang 19.3 / mysql_redis / d15d59a8a19db20a08761e6f4b2c1b81df61965a Reports root/ big OK: 2808 / Failed: 3 / User-skipped: 222 / Auto-skipped: 0
5133.5 / Erlang 19.3 / ldap_mnesia / d15d59a8a19db20a08761e6f4b2c1b81df61965a Reports root/ big OK: 1033 / Failed: 3 / User-skipped: 77 / Auto-skipped: 0
5133.4 / Erlang 19.3 / odbc_mssql_mnesia / d15d59a8a19db20a08761e6f4b2c1b81df61965a Reports root/ big OK: 2822 / Failed: 3 / User-skipped: 208 / Auto-skipped: 0
5133.8 / Erlang 20.0 / pgsql_mnesia / d15d59a8a19db20a08761e6f4b2c1b81df61965a Reports root/ big / small OK: 2854 / Failed: 3 / User-skipped: 176 / Auto-skipped: 0
5133.9 / Erlang 21.0 / riak_mnesia / d15d59a8a19db20a08761e6f4b2c1b81df61965a Reports root/ big / small OK: 1287 / Failed: 6 / User-skipped: 43 / Auto-skipped: 0
Refactor
mongoose_helper:wait_until/{2,3}
for simple and overridable interface and raplace as many as possiblewait_for_SOMETHING
functions in big tests