search

esl / MongooseIM

MongooseIM is Erlang Solutions' robust, scalable and efficient XMPP server, aimed at large installations. Specifically designed for enterprise purposes, it is fault-tolerant and can utilise the resources of multiple clustered machines.
Other
1.64k stars 421 forks source link

Log internal-server-errors in mod_privacy #4139

Closed arcusfelis closed 7 months ago

arcusfelis commented 8 months ago

Log internal-server-errors in mod_privacy. Otherwise you will not see anything in logs, in Mnesia is not started, but mod_privacy is configured with Mnesia backend.

This PR addresses "Nothing in logs, code just ignores Reason variable, which is returned from mod_privacy_backend.

Proposed changes include:

Coverage for the patch is low, because we usually do not test logging.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (2ea4207) 84.08% compared to head (3780cf6) 84.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4139 +/- ## ========================================== - Coverage 84.08% 84.03% -0.06% ========================================== Files 558 558 Lines 34016 34030 +14 ========================================== - Hits 28604 28596 -8 - Misses 5412 5434 +22 ``` | [Files](https://app.codecov.io/gh/esl/MongooseIM/pull/4139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esl) | Coverage Δ | | |---|---|---| | [src/privacy/mod\_privacy.erl](https://app.codecov.io/gh/esl/MongooseIM/pull/4139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esl#diff-c3JjL3ByaXZhY3kvbW9kX3ByaXZhY3kuZXJs) | `85.33% <31.81%> (-3.66%)` | :arrow_down: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/esl/MongooseIM/pull/4139/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=esl)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mongoose-im commented 8 months ago

elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 369 / Failed: 0 / User-skipped: 38 / Auto-skipped: 0

small_tests_24 / small_tests / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root / small

small_tests_25 / small_tests / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root / small

small_tests_25_arm64 / small_tests / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root / small

ldap_mnesia_25 / ldap_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 2303 / Failed: 0 / User-skipped: 864 / Auto-skipped: 0

ldap_mnesia_24 / ldap_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 2303 / Failed: 0 / User-skipped: 864 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4267 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

dynamic_domains_mysql_redis_25 / mysql_redis / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4235 / Failed: 0 / User-skipped: 144 / Auto-skipped: 0

dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4267 / Failed: 0 / User-skipped: 112 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4258 / Failed: 6 / User-skipped: 115 / Auto-skipped: 0

muc_SUITE:register:user_changes_nick ```erlang {error, {{assertion_failed,assert,is_iq_result, [{xmlel,<<"iq">>, [{<<"type">>,<<"set">>}, {<<"id">>,<<"cb6837086ec94af2d257a073ee5899a4">>}, {<<"to">>,<<"groupchats.domain.example.com">>}], [{xmlel,<<"query">>, [{<<"xmlns">>,<<"jabber:iq:register">>}], [{xmlel,<<"x">>, [{<<"xmlns">>,<<"jabber:x:data">>}, {<<"type">>,<<"submit">>}], [{xmlel,<<"field">>, [{<<"type">>,<<"hidden">>}, {<<"var">>,<<"FORM_TYPE">>}], [{xmlel,<<"value">>,[], [{xmlcdata,<<"jabber:iq:register">>}]}]}, {xmlel,<<"field">>, [{<<"type">>,<<"text-single">>}, {<<"var">>,<<"nick">>}], [{xmlel,<<"value">>,[], [{xmlcdata, <<"thirdwitch1room-9f7e156235">>}]}]}]}]}]}], {xmlel,<<"iq">>, [{<<"from">>,<<"groupchats.domain.example.com">>}, {<<"to">>, <<"alice_user_changes_nick_2611@domain.example.com/res1">>}, {<<"type">>,<<"error">>}, {<<"id">>,<<"cb6837086ec94af2d257a073ee5899a4">>}], [{xmlel,<<"query">>, [{<<"xmlns">>,<<"jabber:iq:register">>}], [{xmlel,<<"x">>, [{<<"xmlns">>,<<"jabber:x:data">>}, {<<"type">>,<<"submit">>}], [{xmlel,<<"field">>, [{<<"type">>,<<"hidden">>}, {<<"var">>,<<"FORM_TYPE">>}], [{xm... ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4139/193938/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%408e844158d719.2023-10-04_15.44.04/big_tests.tests.muc_SUITE.logs/run.2023-10-04_15.55.40/muc_suite.user_changes_nick.132227.html)
muc_SUITE:register:user_submits_registration_form ```erlang {error, {thrown, {timeout, [{escalus_connection,receive_stanza,2, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"}, {line,303}]}, {muc_SUITE,'-user_submits_registration_form/1-fun-0-',1, [{file, "/home/circleci/project/big_tests/tests/muc_SUITE.erl"}, {line,2759}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"}, {line,72}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1291}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1223}]}]}}} ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4139/193938/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%408e844158d719.2023-10-04_15.44.04/big_tests.tests.muc_SUITE.logs/run.2023-10-04_15.55.40/muc_suite.user_submits_registration_form.197890.html)
muc_SUITE:register:user_submits_registration_form_twice ```erlang {error, {thrown, {timeout, [{escalus_connection,receive_stanza,2, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"}, {line,303}]}, {muc_SUITE,'-user_submits_registration_form_twice/1-fun-0-',1, [{file, "/home/circleci/project/big_tests/tests/muc_SUITE.erl"}, {line,2773}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"}, {line,72}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1291}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1223}]}]}}} ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4139/193938/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%408e844158d719.2023-10-04_15.44.04/big_tests.tests.muc_SUITE.logs/run.2023-10-04_15.55.40/muc_suite.user_submits_registration_form_twice.197762.html)
muc_SUITE:register:user_unregisters_nick_twice ```erlang {error, {thrown, {timeout, [{escalus_connection,receive_stanza,2, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"}, {line,303}]}, {muc_SUITE,'-user_unregisters_nick_twice/1-fun-0-',1, [{file, "/home/circleci/project/big_tests/tests/muc_SUITE.erl"}, {line,2804}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"}, {line,72}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1291}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1223}]}]}}} ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4139/193938/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%408e844158d719.2023-10-04_15.44.04/big_tests.tests.muc_SUITE.logs/run.2023-10-04_15.55.40/muc_suite.user_unregisters_nick_twice.198146.html)
muc_SUITE:register:user_asks_for_registration_form ```erlang {error, {thrown, {timeout, [{escalus_connection,receive_stanza,2, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"}, {line,303}]}, {muc_SUITE,get_nick,1, [{file, "/home/circleci/project/big_tests/tests/muc_SUITE.erl"}, {line,5116}]}, {muc_SUITE,'-user_asks_for_registration_form/1-fun-0-',1, [{file, "/home/circleci/project/big_tests/tests/muc_SUITE.erl"}, {line,2750}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"}, {line,72}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1291}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1223}]}]}}} ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4139/193938/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%408e844158d719.2023-10-04_15.44.04/big_tests.tests.muc_SUITE.logs/run.2023-10-04_15.55.40/muc_suite.user_asks_for_registration_form.197634.html)
muc_SUITE:register:user_unregisters_nick ```erlang {error, {thrown, {timeout, [{escalus_connection,receive_stanza,2, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_connection.erl"}, {line,303}]}, {muc_SUITE,get_nick,1, [{file, "/home/circleci/project/big_tests/tests/muc_SUITE.erl"}, {line,5116}]}, {muc_SUITE,'-user_unregisters_nick/1-fun-0-',1, [{file, "/home/circleci/project/big_tests/tests/muc_SUITE.erl"}, {line,2795}]}, {escalus_story,story,4, [{file, "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"}, {line,72}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1291}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1223}]}]}}} ``` [Report log](https://circleci-mim-results.s3.eu-central-1.amazonaws.com/PR/4139/193938/odbc_mssql_mnesia.25.3-amd64/big/ct_run.test%408e844158d719.2023-10-04_15.44.04/big_tests.tests.muc_SUITE.logs/run.2023-10-04_15.55.40/muc_suite.user_unregisters_nick.198018.html)

internal_mnesia_25 / internal_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 2453 / Failed: 0 / User-skipped: 714 / Auto-skipped: 0

pgsql_cets_25 / pgsql_cets / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4654 / Failed: 0 / User-skipped: 121 / Auto-skipped: 0

mysql_redis_25 / mysql_redis / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4636 / Failed: 0 / User-skipped: 139 / Auto-skipped: 0

pgsql_mnesia_24 / pgsql_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4656 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

pgsql_mnesia_25 / pgsql_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4656 / Failed: 0 / User-skipped: 119 / Auto-skipped: 0

mssql_mnesia_25 / odbc_mssql_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4653 / Failed: 0 / User-skipped: 122 / Auto-skipped: 0

dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / 3780cf6fa64c0ce83939668ee4e04da7ac73c835 Reports root/ big OK: 4264 / Failed: 0 / User-skipped: 115 / Auto-skipped: 0